Issue 1009283002: [bindings] Split toInt64 into fast inline vs slow non-inline code paths.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1009283002: [bindings] Split toInt64 into fast inline vs slow non-inline code paths. (Closed)

Created:
5 years, 9 months ago by vivekg_samsung

Modified:
5 years, 9 months ago

Reviewers:
haraken, vivekg, Jens Widell

CC:
vivekg, arv+blink, blink-reviews, blink-reviews-bindings_chromium.org, vivekg_samsung

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -19 lines)			Patch
	M	Source/bindings/core/v8/V8Binding.h	View		1 chunk	+14 lines, -1 line	0 comments	Download
	M	Source/bindings/core/v8/V8Binding.cpp	View		1 chunk	+9 lines, -18 lines	0 comments	Download

Total messages: 7 (2 generated)

vivekg

PTAL, I will followup with the Isolate::GetCurrent removal patch.

5 years, 9 months ago (2015-03-16 09:15:26 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1009283002/1

5 years, 9 months ago (2015-03-16 10:54:57 UTC) #5

commit-bot: I haz the power

Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=191904

5 years, 9 months ago (2015-03-16 10:57:51 UTC) #6

Message was sent while issue was closed.

LGTM