Issue 100923011: Initialize high dpi early in the chrome process on Windows by calling the SetProcessDpiAware API in…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 100923011: Initialize high dpi early in the chrome process on Windows by calling the SetProcessDpiAware API in… (Closed)

Created:
7 years ago by ananta

Modified:
7 years ago

Reviewers:
cpu_(ooo_6.6-7.5), sky

CC:
chromium-reviews, joi+watch-content_chromium.org, piman+watch_chromium.org, jam, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Initialize high dpi early in the chrome process on Windows by calling the SetProcessDpiAware API in chrome.exe instead of chrome.dll This API needs to be invoked as early as possible in the process. Not doing this causes the OS to assume that the process needs dpi scaling which leads to bad things. We also need to initialize high dpi in the gpu process as it is involved in win32 operations like painting, etc. BUG=330093 R=cpu@chromium.org TBR=sky Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=242182

	Unified diffs	Side-by-side diffs	Stats (+10 lines, -4 lines)			Patch
M	chrome/app/chrome_exe_main_win.cc	View	2 chunks	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/chrome_browser_main.cc	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	chrome/chrome_exe.gypi	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	content/browser/gpu/gpu_process_host.cc	View	2 chunks	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

cpu_(ooo_6.6-7.5)

lgtm As long as chrome.exe does not grow more than a few kilobytes with this ...

7 years ago (2013-12-20 20:39:06 UTC) #2

Message was sent while issue was closed.

Committed patchset #5 manually as r242182.

Expand Messages | Collapse Messages

Issue 100923011: Initialize high dpi early in the chrome process on Windows by calling the SetProcessDpiAware API in… (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Messages