Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 100923006: Roll Breakpad r1240:r1247. (Closed)

Created:
7 years ago by Mostyn Bramley-Moore
Modified:
7 years ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews
Visibility:
Public.

Description

Roll Breakpad r1240:r1247. r1247: Back out r1244 r1246: switch armv7 setting to arm_version==7 in breakpad r1245: Add include guards and avoid redefinition of false/true in convert_UTF. r1244: Avoid redefinition of global static debug flag and remove unneeded #import "GTMDefines.h r1243: Do not read CFI section when not outputing CFI information. r1242: Fix unused method warning. r1241: Fixing several instances of wrong printf format specifiers. BUG=234135 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=239555

Patch Set 1 #

Patch Set 2 : roll to r1247 instead #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (0 generated)
Mostyn Bramley-Moore
@mark: here's the breakpad roll...
7 years ago (2013-12-08 20:02:55 UTC) #1
Mark Mentovai
Please format the commit message the same way as recent Breakpad rolls, to make it ...
7 years ago (2013-12-08 22:30:44 UTC) #2
Mark Mentovai
Please format the commit message the same way as recent Breakpad rolls, to make it ...
7 years ago (2013-12-08 22:30:46 UTC) #3
Mostyn Bramley-Moore
How's this? Is it OK to leave the BUG entry corresponding to r1246, but not ...
7 years ago (2013-12-08 23:06:37 UTC) #4
Mark Mentovai
Yes. Well, you should still say something about “roll Breakpad” in the first line of ...
7 years ago (2013-12-09 02:18:06 UTC) #5
Mostyn Bramley-Moore
On 2013/12/09 02:18:06, Mark Mentovai wrote: > Yes. Well, you should still say something about ...
7 years ago (2013-12-09 07:57:18 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mostynb@opera.com/100923006/1
7 years ago (2013-12-09 07:57:30 UTC) #7
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) base_unittests, browser_tests, interactive_ui_tests, net_unittests, unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=198809
7 years ago (2013-12-09 08:11:23 UTC) #8
Mostyn Bramley-Moore
I think r1244 introduced mac breakage, blocking this roll: https://breakpad.appspot.com/824002/
7 years ago (2013-12-09 08:19:40 UTC) #9
Mark Mentovai
OK, try r1247.
7 years ago (2013-12-09 14:11:00 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mostynb@opera.com/100923006/20001
7 years ago (2013-12-09 14:30:58 UTC) #11
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) content_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=233223
7 years ago (2013-12-09 17:16:53 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mostynb@opera.com/100923006/20001
7 years ago (2013-12-09 19:17:53 UTC) #13
commit-bot: I haz the power
7 years ago (2013-12-09 21:30:55 UTC) #14
Message was sent while issue was closed.
Change committed as 239555

Powered by Google App Engine
This is Rietveld 408576698