extensions/browser/guest_view/guest_view_base.h - Issue 1009193003: Make options zoom isolated, match embedder zoom on navigation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/guest_view/guest_view_base.h

Issue 1009193003: Make options zoom isolated, match embedder zoom on navigation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Don't DCHECK embedder zoom controller existence. Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/browser/guest_view/extension_options/extension_options_guest.cc ('k') | extensions/browser/guest_view/guest_view_base.cc » ('j') | extensions/browser/guest_view/guest_view_base.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/guest_view/guest_view_base.h

diff --git a/extensions/browser/guest_view/guest_view_base.h b/extensions/browser/guest_view/guest_view_base.h

index 17eac480237f00844d3bfddaeb454d57c0baac5c..a7ea60ac20416920162ed7b55486bdcd64838b26 100644

--- a/extensions/browser/guest_view/guest_view_base.h

+++ b/extensions/browser/guest_view/guest_view_base.h

@@ -327,6 +327,9 @@ class GuestViewBase : public content::BrowserPluginGuestDelegate,

void DidStopLoading() final;

void RenderViewReady() final;

void WebContentsDestroyed() final;

+ void DidNavigateMainFrame(

+ const content::LoadCommittedDetails& details,

+ const content::FrameNavigateParams& params) override;

// WebContentsDelegate implementation.

void ActivateContents(content::WebContents* contents) final;

@@ -353,6 +356,8 @@ class GuestViewBase : public content::BrowserPluginGuestDelegate,

const gfx::Size& pref_size) final;

void UpdateTargetURL(content::WebContents* source, const GURL& url) override;

+ void SetGuestZoomLevelToMatchEmbedder();

private:

class OwnerContentsObserver;