Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 1009183002: swith over from SkPaint::FilterLevel to SkFilterQuality (Closed)

Created:
5 years, 9 months ago by reed2
Modified:
5 years, 9 months ago
Reviewers:
scroggo, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

swith over from SkPaint::FilterLevel to SkFilterQuality BUG=skia: needed manual rebase -- abandoning in favor of https://codereview.chromium.org/1014533004/

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+367 lines, -355 lines) Patch
M bench/AlternatingColorPatternBench.cpp View 1 chunk +1 line, -1 line 0 comments Download
M bench/Benchmark.cpp View 1 chunk +1 line, -1 line 0 comments Download
M bench/BitmapBench.cpp View 1 chunk +6 lines, -6 lines 0 comments Download
M bench/BitmapRectBench.cpp View 4 chunks +11 lines, -11 lines 0 comments Download
M bench/BitmapScaleBench.cpp View 1 chunk +1 line, -1 line 0 comments Download
M bench/GameBench.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M bench/TileBench.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M debugger/QT/SkSettingsWidget.cpp View 1 2 1 chunk +5 lines, -5 lines 0 comments Download
M gm/bigmatrix.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/bitmapfilters.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/bleed.cpp View 6 chunks +36 lines, -36 lines 0 comments Download
M gm/blurquickreject.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/clippedbitmapshaders.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/downsamplebitmap.cpp View 6 chunks +32 lines, -32 lines 0 comments Download
M gm/drawbitmaprect.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/filterbitmap.cpp View 2 chunks +6 lines, -6 lines 0 comments Download
M gm/filterfastbounds.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M gm/filterindiabox.cpp View 2 chunks +6 lines, -6 lines 0 comments Download
M gm/giantbitmap.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/imagefiltersclipped.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/imagefiltersscaled.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/imageresizetiled.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/matriximagefilter.cpp View 2 chunks +6 lines, -6 lines 0 comments Download
M gm/mipmap.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/ninepatchstretch.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/pictureimagefilter.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M gm/resizeimagefilter.cpp View 4 chunks +7 lines, -7 lines 0 comments Download
M gm/shadertext2.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/shadertext3.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M gm/tallstretchedbitmaps.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/tiledscaledbitmap.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/tilemodes.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/tilemodes_scaled.cpp View 4 chunks +10 lines, -10 lines 0 comments Download
M include/core/SkPaint.h View 3 chunks +2 lines, -3 lines 0 comments Download
M include/effects/SkMatrixImageFilter.h View 3 chunks +11 lines, -3 lines 0 comments Download
M include/effects/SkPictureImageFilter.h View 4 chunks +13 lines, -6 lines 0 comments Download
M samplecode/SampleAll.cpp View 1 chunk +1 line, -1 line 0 comments Download
M samplecode/SampleApp.h View 1 chunk +1 line, -1 line 0 comments Download
M samplecode/SampleApp.cpp View 8 chunks +26 lines, -26 lines 0 comments Download
M samplecode/SampleBitmapRect.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M samplecode/SampleCamera.cpp View 1 chunk +1 line, -1 line 0 comments Download
M samplecode/SampleFilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M samplecode/SampleFilter2.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M samplecode/SampleFilterFuzz.cpp View 1 chunk +1 line, -1 line 0 comments Download
M samplecode/SampleFilterQuality.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M samplecode/SampleIdentityScale.cpp View 1 chunk +1 line, -1 line 0 comments Download
M samplecode/SamplePatch.cpp View 1 chunk +1 line, -1 line 0 comments Download
M samplecode/SampleSlides.cpp View 1 chunk +1 line, -1 line 0 comments Download
M samplecode/SampleSubpixelTranslate.cpp View 2 chunks +17 lines, -17 lines 0 comments Download
M samplecode/SampleTextureDomain.cpp View 1 chunk +1 line, -1 line 0 comments Download
M samplecode/SampleTiling.cpp View 1 chunk +1 line, -1 line 0 comments Download
M samplecode/SampleVertices.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/animator/SkDrawPaint.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkBitmapProcShader.cpp View 2 chunks +5 lines, -5 lines 0 comments Download
M src/core/SkBitmapProcState.cpp View 15 chunks +23 lines, -23 lines 0 comments Download
M src/core/SkBitmapProcState_matrixProcs.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/core/SkBitmapProcState_sample.h View 5 chunks +5 lines, -5 lines 0 comments Download
M src/core/SkBitmapProcState_shaderproc.h View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkPaint.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M src/effects/SkBitmapSource.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/effects/SkMatrixImageFilter.cpp View 3 chunks +9 lines, -9 lines 0 comments Download
M src/effects/SkPictureImageFilter.cpp View 4 chunks +9 lines, -9 lines 0 comments Download
M src/effects/SkTestImageFilters.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/SkGpuDevice.cpp View 2 chunks +6 lines, -6 lines 0 comments Download
M src/opts/SkBitmapProcState_opts_SSE2.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M src/opts/SkBitmapProcState_opts_SSSE3.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/opts/SkBitmapProcState_opts_arm.cpp View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M src/opts/SkBitmapProcState_opts_mips_dsp.cpp View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M src/pipe/SkGPipeRead.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/pipe/SkGPipeWrite.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M src/ports/SkFontHost_FreeType_common.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M src/utils/SkLua.cpp View 2 chunks +6 lines, -6 lines 0 comments Download
M src/utils/debugger/SkDebugCanvas.h View 1 chunk +1 line, -1 line 0 comments Download
M src/utils/debugger/SkDebugCanvas.cpp View 2 chunks +7 lines, -7 lines 0 comments Download
M tests/DrawBitmapRectTest.cpp View 1 chunk +6 lines, -6 lines 0 comments Download
M tests/ImageFilterTest.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M tests/PaintTest.cpp View 3 chunks +18 lines, -20 lines 0 comments Download
M tests/SkResourceCacheTest.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 22 (10 generated)
reed2
need to check android ...
5 years, 9 months ago (2015-03-15 19:56:52 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1009183002/1
5 years, 9 months ago (2015-03-15 20:44:03 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 9 months ago (2015-03-15 20:44:04 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1009183002/20001
5 years, 9 months ago (2015-03-15 21:00:54 UTC) #8
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 9 months ago (2015-03-15 21:00:55 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1009183002/40001
5 years, 9 months ago (2015-03-15 21:10:20 UTC) #12
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 9 months ago (2015-03-15 21:10:21 UTC) #13
scroggo
On 2015/03/15 19:56:52, reed2 wrote: > need to check android ... I see five instances: ...
5 years, 9 months ago (2015-03-16 12:58:53 UTC) #15
reed1
ptal -- android call sites updated
5 years, 9 months ago (2015-03-16 15:40:20 UTC) #17
scroggo
On 2015/03/16 15:40:20, reed1 wrote: > ptal -- android call sites updated LGTM
5 years, 9 months ago (2015-03-16 15:41:16 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1009183002/40001
5 years, 9 months ago (2015-03-16 15:42:18 UTC) #20
commit-bot: I haz the power
5 years, 9 months ago (2015-03-16 15:42:38 UTC) #22
Failed to apply patch for include/core/SkPaint.h:
While running git apply --index -3 -p1;
  error: patch failed: include/core/SkPaint.h:338
  Falling back to three-way merge...
  Applied patch to 'include/core/SkPaint.h' with conflicts.
  U include/core/SkPaint.h

Patch:       include/core/SkPaint.h
Index: include/core/SkPaint.h
diff --git a/include/core/SkPaint.h b/include/core/SkPaint.h
index
bb5eff4d91cc47084e3e92ad5145e7c6a1d3e367..d5c750666de009cec068f67528dda69733958b50
100644
--- a/include/core/SkPaint.h
+++ b/include/core/SkPaint.h
@@ -14,9 +14,6 @@
 #include "SkMatrix.h"
 #include "SkXfermode.h"
 
-// TODO: clean up Skia internals so we can remove this and only keep it for
clients
-#define SK_SUPPORT_LEGACY_FILTERLEVEL_ENUM
-
 class SkAnnotation;
 class SkAutoGlyphCache;
 class SkColorFilter;
@@ -338,6 +335,7 @@ public:
      */
     void setFilterQuality(SkFilterQuality quality);
 
+#ifdef SK_SUPPORT_LEGACY_FILTERLEVEL_ENUM
     /**
      *  If the predicate is true, set the filterLevel to Low, else set it to
      *  None.
@@ -354,6 +352,7 @@ public:
     bool isFilterBitmap() const {
         return kNone_FilterLevel != this->getFilterLevel();
     }
+#endif
 
     /** Styles apply to rect, oval, path, and text.
         Bitmaps are always drawn in "fill", and lines are always drawn in

Powered by Google App Engine
This is Rietveld 408576698