Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 1009143002: [bindings] Split toInt32 into fast inline and slower non-inline path. (Closed)

Created:
5 years, 9 months ago by vivekg_samsung
Modified:
5 years, 9 months ago
Reviewers:
haraken, vivekg, Jens Widell
CC:
blink-reviews, blink-reviews-bindings_chromium.org, vivekg_samsung, arv+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[bindings] Split toInt32 into fast inline and slower non-inline path. Optimize the faster cases by inlining the fast code path. Rest of the code would remain as a non-inline code path. R=jl@opera.com, haraken@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191888

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -21 lines) Patch
M Source/bindings/core/v8/V8Binding.h View 1 chunk +11 lines, -1 line 0 comments Download
M Source/bindings/core/v8/V8Binding.cpp View 1 chunk +12 lines, -20 lines 1 comment Download

Messages

Total messages: 7 (2 generated)
vivekg
PTAL, thanks.
5 years, 9 months ago (2015-03-15 12:53:13 UTC) #2
haraken
LGTM https://codereview.chromium.org/1009143002/diff/1/Source/bindings/core/v8/V8Binding.cpp File Source/bindings/core/v8/V8Binding.cpp (right): https://codereview.chromium.org/1009143002/diff/1/Source/bindings/core/v8/V8Binding.cpp#newcode328 Source/bindings/core/v8/V8Binding.cpp:328: v8::Isolate* isolate = v8::Isolate::GetCurrent(); Not related to this ...
5 years, 9 months ago (2015-03-15 14:55:02 UTC) #3
vivekg
On 2015/03/15 14:55:02, haraken wrote: > LGTM > > https://codereview.chromium.org/1009143002/diff/1/Source/bindings/core/v8/V8Binding.cpp > File Source/bindings/core/v8/V8Binding.cpp (right): > ...
5 years, 9 months ago (2015-03-15 15:25:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1009143002/1
5 years, 9 months ago (2015-03-15 15:43:05 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-15 15:45:40 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=191888

Powered by Google App Engine
This is Rietveld 408576698