[bindings] Split toInt32 into fast inline and slower non-inline path.

[bindings] Split toInt32 into fast inline and slower non-inline path.

Optimize the faster cases by inlining the fast code path. Rest of the code would remain as
a non-inline code path.

R=jl@opera.com, haraken@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191888

[vivekg, 2015-03-15 12:53:13]

vivekg@chromium.org changed reviewers:
+ vivekg@chromium.org

[vivekg, 2015-03-15 12:53:13]

PTAL, thanks.

[haraken, 2015-03-15 14:55:02]

LGTM

https://codereview.chromium.org/1009143002/diff/1/Source/bindings/core/v8/V8B...
File Source/bindings/core/v8/V8Binding.cpp (right):

https://codereview.chromium.org/1009143002/diff/1/Source/bindings/core/v8/V8B...
Source/bindings/core/v8/V8Binding.cpp:328: v8::Isolate* isolate =
v8::Isolate::GetCurrent();

Not related to this CL, we should remove this Isolate::GetCurrent by passing in
the Isolate parameter to this method...

[vivekg, 2015-03-15 15:25:40]

On 2015/03/15 14:55:02, haraken wrote:
> LGTM
> 
>
https://codereview.chromium.org/1009143002/diff/1/Source/bindings/core/v8/V8B...
> File Source/bindings/core/v8/V8Binding.cpp (right):
> 
>
https://codereview.chromium.org/1009143002/diff/1/Source/bindings/core/v8/V8B...
> Source/bindings/core/v8/V8Binding.cpp:328: v8::Isolate* isolate =
> v8::Isolate::GetCurrent();
> 
> Not related to this CL, we should remove this Isolate::GetCurrent by passing
in
> the Isolate parameter to this method...

Sure, I will do that in a follow up patch.

Thanks for your review. Though I always wonder about your timezone of work as I
get your reviews very quickly at any time of the day. He he ;)

[vivekg, 2015-03-15 15:42:59]

The CQ bit was checked by vivekg@chromium.org

[commit-bot: I haz the power, 2015-03-15 15:43:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1009143002/1

[commit-bot: I haz the power, 2015-03-15 15:45:40]

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=191888