Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 1009053002: Revert "Revert "add new signature so skia can rely on it (subclass of SkDevice)"" (Closed)

Created:
5 years, 9 months ago by reed2
Modified:
5 years, 9 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Revert "add new signature so skia can rely on it (subclass of SkDevice)"" Now with "override" to merge with skia's new virtual Intended to allow this to land in skia https://codereview.chromium.org/1005183003 This reverts commit 3d4669df835748357f3865d6d01a155fe72f298e. BUG= TBR=fmalita@chromium.org Committed: https://crrev.com/3d74de25969674b68feb6080d947b3414c3963cd Cr-Commit-Position: refs/heads/master@{#320659}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -0 lines) Patch
M skia/ext/bitmap_platform_device_cairo.h View 1 chunk +1 line, -0 lines 0 comments Download
M skia/ext/bitmap_platform_device_cairo.cc View 1 1 chunk +7 lines, -0 lines 0 comments Download
M skia/ext/bitmap_platform_device_mac.h View 1 chunk +1 line, -0 lines 0 comments Download
M skia/ext/bitmap_platform_device_mac.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M skia/ext/bitmap_platform_device_skia.h View 1 chunk +1 line, -0 lines 0 comments Download
M skia/ext/bitmap_platform_device_skia.cc View 1 1 chunk +7 lines, -0 lines 0 comments Download
M skia/ext/bitmap_platform_device_win.h View 1 chunk +1 line, -0 lines 0 comments Download
M skia/ext/bitmap_platform_device_win.cc View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1009053002/1
5 years, 9 months ago (2015-03-14 13:36:24 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1009053002/20001
5 years, 9 months ago (2015-03-14 13:50:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1009053002/20001
5 years, 9 months ago (2015-03-14 16:33:55 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-14 17:11:48 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-14 17:12:41 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3d74de25969674b68feb6080d947b3414c3963cd
Cr-Commit-Position: refs/heads/master@{#320659}

Powered by Google App Engine
This is Rietveld 408576698