ash/wm/workspace_controller.cc - Issue 100903002: Ignore fullscreen windows which are behind other windows for fullscreen mode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/wm/workspace_controller.cc

Issue 100903002: Ignore fullscreen windows which are behind other windows for fullscreen mode. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Add multi-monitor test. Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ash/wm/workspace/workspace_layout_manager.cc ('k') | content/browser/renderer_host/render_widget_host_view_aura.h » ('j') | content/browser/renderer_host/render_widget_host_view_aura.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ash/wm/workspace_controller.cc

diff --git a/ash/wm/workspace_controller.cc b/ash/wm/workspace_controller.cc

index 8d378581401f3bc96bfff2a02e09dc97dcd21377..9d9966c5f3401f61b1bcff8fc7f456d1e6602fba 100644

--- a/ash/wm/workspace_controller.cc

+++ b/ash/wm/workspace_controller.cc

@@ -74,7 +74,8 @@ WorkspaceWindowState WorkspaceController::GetWindowState() const {

// An untracked window may still be fullscreen so we keep iterating when

// we hit a maximized window.

has_maximized_window = true;

- } else if (window_state->IsFullscreen()) {

+ } else if (*i == windows.back() && window_state->IsFullscreen()) {

flackr 2013/12/03 22:05:55 Hang on, this check for topmost doesn't seem to be

+ // Only enter the full screen state if the topmost window is fullscreen.

return WORKSPACE_WINDOW_STATE_FULL_SCREEN;

}

if (!window_overlaps_launcher && (*i)->bounds().Intersects(shelf_bounds))