Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2601)

Unified Diff: ash/wm/overview/window_selector_unittest.cc

Issue 100903002: Ignore fullscreen windows which are behind other windows for fullscreen mode. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/wm/overview/window_selector_unittest.cc
diff --git a/ash/wm/overview/window_selector_unittest.cc b/ash/wm/overview/window_selector_unittest.cc
index a8e8d08ecccd6022aaa396ea66bef78210afe921..ca198783b8713b082d673166c6d5683fa4957b87 100644
--- a/ash/wm/overview/window_selector_unittest.cc
+++ b/ash/wm/overview/window_selector_unittest.cc
@@ -284,12 +284,13 @@ TEST_F(WindowSelectorTest, FullscreenWindow) {
EXPECT_TRUE(wm::GetWindowState(window1.get())->IsFullscreen());
EXPECT_FALSE(panel1->IsVisible());
- // Entering overview and selecting another window should exit fullscreen.
+ // Entering overview and selecting another window, the previous window remains
+ // fullscreen.
// TODO(flackr): Currently the panel remains hidden, but should become visible
// again.
ToggleOverview();
ClickWindow(window2.get());
- EXPECT_FALSE(wm::GetWindowState(window1.get())->IsFullscreen());
+ EXPECT_TRUE(wm::GetWindowState(window1.get())->IsFullscreen());
}
// Tests that the shelf dimming state is removed while in overview and restored

Powered by Google App Engine
This is Rietveld 408576698