Ignore fullscreen windows which are behind other windows for fullscreen mode.

ash/root_window_controller.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/root_window_controller.h"
 
 #include <queue>
 #include <vector>
 
 #include "ash/ash_constants.h"
@@ skipping 500 matching lines @@
     return;
   }
 
   Shell::GetInstance()->UpdateShelfVisibility();
 }
 
 void RootWindowController::UpdateShelfVisibility() {
   shelf_->shelf_layout_manager()->UpdateVisibilityState();
 }
 
 const aura::Window* RootWindowController::GetTopmostFullscreenWindow() const {

[pkotwicz, 2013/12/05 02:46:29]

Would GetWindowForFullscreenMode() / GetFullscreenModeWindow() be clearer?

[flackr, 2013/12/05 16:48:54]

Sounds like a good name to me, done.

   const aura::Window::Windows& windows =
       GetContainer(kShellWindowId_DefaultContainer)->children();
+  const aura::Window* topmost_fullscreen_window = NULL;

[pkotwicz, 2013/12/05 02:46:29]

Rename to |topmost_window|.

[flackr, 2013/12/05 16:48:54]

Done.

   for (aura::Window::Windows::const_reverse_iterator iter = windows.rbegin();
        iter != windows.rend(); ++iter) {
-    if (wm::GetWindowState(*iter)->IsFullscreen())
-      return *iter;
+    if ((*iter)->type() != aura::client::WINDOW_TYPE_POPUP &&
+        (*iter)->layer()->GetTargetVisibility() &&
+        (*iter)->layer()->GetTargetOpacity() != 0.0f) {

[pkotwicz, 2013/12/05 02:46:29]

I wonder whether the target opacity check is still necessary or whether it is
left over from when we had workspaces

[flackr, 2013/12/05 16:48:54]

Looks like this has been the case since the maximized and overlaps states were
implemented (which was when we had workspaces),
https://chromiumcodereview.appspot.com/9764008/diff/2001/ash/wm/workspace/wor....


+Scott, I've played around with this with the check removed and things seem
fine. Are there circumstances where we make things 0 opacity but don't change
the target visibility?

+      topmost_fullscreen_window = *iter;
+      break;
+    }
+  }
+  while (topmost_fullscreen_window) {
+    if (wm::GetWindowState(topmost_fullscreen_window)->IsFullscreen())
+      return topmost_fullscreen_window;
+    topmost_fullscreen_window = topmost_fullscreen_window->transient_parent();
   }
   return NULL;
 }
 
 aura::Window* RootWindowController::GetTopmostFullscreenWindow() {
   return const_cast<aura::Window*>(
       const_cast<const RootWindowController*>(this)->
           GetTopmostFullscreenWindow());
 }
 
@@ skipping 391 matching lines @@
     DisableTouchHudProjection();
 }
 
 RootWindowController* GetRootWindowController(
     const aura::Window* root_window) {
   return root_window ? GetRootWindowSettings(root_window)->controller : NULL;
 }
 
 }  // namespace internal
 }  // namespace ash