Issue 1009023002: Create a TcpCubicSender in QUIC that tracks the congestion window in

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1009023002: Create a TcpCubicSender in QUIC that tracks the congestion window in (Closed)

Created:
5 years, 9 months ago by ramant (doing other things)

Modified:
5 years, 9 months ago

Reviewers:
Ian Swett, Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@Remove_flag_quic_enable_pacing_88152071

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Create a TcpCubicSender in QUIC that tracks the congestion window in bytes, instead of packets. Merge internal change: 88159377 R=ianswett@google.com, rch@chromium.org

Patch Set 1 #

Total comments: 1

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+424 lines, -313 lines)			Patch
M	net/net.gypi	View	4 chunks	+6 lines, -0 lines	0 comments	Download
A +	net/quic/congestion_control/cubic_bytes.h	View	4 chunks	+24 lines, -23 lines	0 comments	Download
A +	net/quic/congestion_control/cubic_bytes.cc	View	10 chunks	+31 lines, -38 lines	0 comments	Download
A	net/quic/congestion_control/cubic_bytes_test.cc	View	1 chunk	+157 lines, -0 lines	0 comments	Download
A +	net/quic/congestion_control/tcp_cubic_bytes_sender.h	View	5 chunks	+25 lines, -30 lines	0 comments	Download
A +	net/quic/congestion_control/tcp_cubic_bytes_sender.cc	View	17 chunks	+79 lines, -86 lines	0 comments	Download
A +	net/quic/congestion_control/tcp_cubic_bytes_sender_test.cc	View	29 chunks	+101 lines, -134 lines	0 comments	Download
M	net/quic/congestion_control/tcp_cubic_sender.h	View	1 chunk	+1 line, -2 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ramant (doing other things)

https://codereview.chromium.org/1009023002/diff/1/net/quic/congestion_control/tcp_cubic_sender.h File net/quic/congestion_control/tcp_cubic_sender.h (right): https://codereview.chromium.org/1009023002/diff/1/net/quic/congestion_control/tcp_cubic_sender.h#newcode5 net/quic/congestion_control/tcp_cubic_sender.h:5: // TCP cubic send side congestion algorithm, emulates the ...

5 years, 9 months ago (2015-03-14 01:21:47 UTC) #2

lgtm

Expand Messages | Collapse Messages