Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4348)

Unified Diff: cc/surfaces/display.h

Issue 1009013002: Use NOTREACHED in Display OutputSurfaceClient implementations. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | cc/surfaces/display.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/surfaces/display.h
diff --git a/cc/surfaces/display.h b/cc/surfaces/display.h
index 9c5a349626a6646e5f24b67cb1722c5bb96d4e45..78b3054c9e0f52f4f9b62161179420c91bb7d8e1 100644
--- a/cc/surfaces/display.h
+++ b/cc/surfaces/display.h
@@ -66,14 +66,14 @@ class CC_SURFACES_EXPORT Display : public OutputSurfaceClient,
int GetMaxFramesPending();
// OutputSurfaceClient implementation.
- void DeferredInitialize() override {}
- void ReleaseGL() override {}
+ void DeferredInitialize() override;
+ void ReleaseGL() override;
void CommitVSyncParameters(base::TimeTicks timebase,
base::TimeDelta interval) override;
- void SetNeedsRedrawRect(const gfx::Rect& damage_rect) override {}
+ void SetNeedsRedrawRect(const gfx::Rect& damage_rect) override;
void DidSwapBuffers() override;
void DidSwapBuffersComplete() override;
- void ReclaimResources(const CompositorFrameAck* ack) override {}
+ void ReclaimResources(const CompositorFrameAck* ack) override;
void DidLoseOutputSurface() override;
void SetExternalDrawConstraints(
const gfx::Transform& transform,
@@ -81,13 +81,13 @@ class CC_SURFACES_EXPORT Display : public OutputSurfaceClient,
const gfx::Rect& clip,
const gfx::Rect& viewport_rect_for_tile_priority,
const gfx::Transform& transform_for_tile_priority,
- bool resourceless_software_draw) override {}
+ bool resourceless_software_draw) override;
void SetMemoryPolicy(const ManagedMemoryPolicy& policy) override;
- void SetTreeActivationCallback(const base::Closure& callback) override {}
+ void SetTreeActivationCallback(const base::Closure& callback) override;
void OnDraw() override;
// RendererClient implementation.
- void SetFullRootLayerDamage() override {}
+ void SetFullRootLayerDamage() override;
// SurfaceDamageObserver implementation.
void OnSurfaceDamaged(SurfaceId surface, bool* changed) override;
« no previous file with comments | « no previous file | cc/surfaces/display.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698