Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Side by Side Diff: cc/surfaces/display.cc

Issue 1009013002: Use NOTREACHED in Display OutputSurfaceClient implementations. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « cc/surfaces/display.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "cc/surfaces/display.h" 5 #include "cc/surfaces/display.h"
6 6
7 #include "base/message_loop/message_loop.h" 7 #include "base/message_loop/message_loop.h"
8 #include "base/trace_event/trace_event.h" 8 #include "base/trace_event/trace_event.h"
9 #include "cc/debug/benchmark_instrumentation.h" 9 #include "cc/debug/benchmark_instrumentation.h"
10 #include "cc/output/compositor_frame.h" 10 #include "cc/output/compositor_frame.h"
(...skipping 182 matching lines...) Expand 10 before | Expand all | Expand 10 after
193 } 193 }
194 194
195 void Display::SetMemoryPolicy(const ManagedMemoryPolicy& policy) { 195 void Display::SetMemoryPolicy(const ManagedMemoryPolicy& policy) {
196 client_->SetMemoryPolicy(policy); 196 client_->SetMemoryPolicy(policy);
197 } 197 }
198 198
199 void Display::OnDraw() { 199 void Display::OnDraw() {
200 NOTREACHED(); 200 NOTREACHED();
201 } 201 }
202 202
203 void Display::DeferredInitialize() {
204 NOTREACHED();
205 }
206
207 void Display::ReleaseGL() {
208 NOTREACHED();
209 }
210
211 void Display::SetNeedsRedrawRect(const gfx::Rect& damage_rect) {
212 NOTREACHED();
213 }
214
215 void Display::ReclaimResources(const CompositorFrameAck* ack) {
216 NOTREACHED();
217 }
218
219 void Display::SetExternalDrawConstraints(
220 const gfx::Transform& transform,
221 const gfx::Rect& viewport,
222 const gfx::Rect& clip,
223 const gfx::Rect& viewport_rect_for_tile_priority,
224 const gfx::Transform& transform_for_tile_priority,
225 bool resourceless_software_draw) {
226 NOTREACHED();
227 }
228
229 void Display::SetTreeActivationCallback(const base::Closure& callback) {
230 NOTREACHED();
231 }
232
233 void Display::SetFullRootLayerDamage() {
234 NOTREACHED();
235 }
236
203 void Display::OnSurfaceDamaged(SurfaceId surface_id, bool* changed) { 237 void Display::OnSurfaceDamaged(SurfaceId surface_id, bool* changed) {
204 if (aggregator_ && 238 if (aggregator_ &&
205 aggregator_->previous_contained_surfaces().count(surface_id)) { 239 aggregator_->previous_contained_surfaces().count(surface_id)) {
206 Surface* surface = manager_->GetSurfaceForId(surface_id); 240 Surface* surface = manager_->GetSurfaceForId(surface_id);
207 if (surface) { 241 if (surface) {
208 const CompositorFrame* current_frame = surface->GetEligibleFrame(); 242 const CompositorFrame* current_frame = surface->GetEligibleFrame();
209 if (!current_frame || !current_frame->delegated_frame_data || 243 if (!current_frame || !current_frame->delegated_frame_data ||
210 !current_frame->delegated_frame_data->resource_list.size()) 244 !current_frame->delegated_frame_data->resource_list.size())
211 aggregator_->ReleaseResources(surface_id); 245 aggregator_->ReleaseResources(surface_id);
212 } 246 }
(...skipping 11 matching lines...) Expand all
224 258
225 int Display::GetMaxFramesPending() { 259 int Display::GetMaxFramesPending() {
226 int max_frames_pending = 260 int max_frames_pending =
227 output_surface_ ? output_surface_->capabilities().max_frames_pending : 0; 261 output_surface_ ? output_surface_->capabilities().max_frames_pending : 0;
228 if (max_frames_pending <= 0) 262 if (max_frames_pending <= 0)
229 max_frames_pending = OutputSurface::DEFAULT_MAX_FRAMES_PENDING; 263 max_frames_pending = OutputSurface::DEFAULT_MAX_FRAMES_PENDING;
230 return max_frames_pending; 264 return max_frames_pending;
231 } 265 }
232 266
233 } // namespace cc 267 } // namespace cc
OLDNEW
« no previous file with comments | « cc/surfaces/display.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698