Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1095)

Issue 1008973004: hack on linear gradient (Closed)

Created:
5 years, 9 months ago by mtklein_C
Modified:
5 years, 9 months ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

hack on linear gradient Am I going nuts or can we get this down to just adds and converts in the loop? #floats #n9 BUG=skia:3592 CQ_INCLUDE_TRYBOTS=client.skia.android:Test-Android-Nexus9-TegraK1-Arm64-Release-Trybot Committed: https://skia.googlesource.com/skia/+/02fd592c8d190058652bb715fb34feb7a72992e5

Patch Set 1 #

Patch Set 2 : undo #

Patch Set 3 : back to get() for now #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -6 lines) Patch
M bench/PMFloatBench.cpp View 1 2 2 chunks +41 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
mtklein_C
Can't land this without fleshing out trunc(), but it should be enough to patch, play ...
5 years, 9 months ago (2015-03-25 00:38:18 UTC) #2
reed1
lgtm
5 years, 9 months ago (2015-03-25 20:19:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1008973004/40001
5 years, 9 months ago (2015-03-25 21:29:00 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-26 01:13:08 UTC) #7
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/02fd592c8d190058652bb715fb34feb7a72992e5

Powered by Google App Engine
This is Rietveld 408576698