[Extensions UI] Update extensions page to use api methods for permissions prompt

chrome/browser/extensions/api/developer_private/show_permissions_dialog_helper.h

+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_EXTENSIONS_API_DEVELOPER_PRIVATE_SHOW_PERMISSIONS_DIALOG_HELPER_H_
+#define CHROME_BROWSER_EXTENSIONS_API_DEVELOPER_PRIVATE_SHOW_PERMISSIONS_DIALOG_HELPER_H_
+
+#include "base/bind.h"
+#include "base/memory/scoped_ptr.h"
+#include "chrome/browser/extensions/extension_install_prompt.h"
+
+class Profile;
+
+namespace content {
+class BrowserContext;
+class WebContents;
+}
+
+namespace extensions {
+class Extension;
+
+// Helper class to handle showing a permissions dialog for an extension. Will
+// show either the newer AppInfo-style permissions dialog, or the traditional,
+// install-prompt style dialog.
+class ShowPermissionsDialogHelper : public ExtensionInstallPrompt::Delegate {
+ public:
+  static void Show(content::WebContents* web_contents,
+                   content::BrowserContext* browser_context,

[not at google - send to devlin, 2015/03/16 17:39:55]

I don't think it's necessarily worth taking action on this comment, by anyway:

I personally prefer to order my parameters from most to least scope. Possibly
because of functional languages (and now base::Bind) when functions are
typically passed though some state, then Run()-d with a specific parameter. In
this case, put the browsercontext before the webcontents.

That said, there's a GetBrowserContext() method on WebContents if you want to
avoid this altogether.

[Devlin, 2015/03/16 21:10:55]

I figured best to avoid the GetBrowserContext() on the web_contents on the crazy
offchance that they are different (one incognito?).  Not that that can happen
yet, but figured might as well be prepared.

Happy to reorder, though - done.

+                   const Extension* extension,
+                   bool from_extensions_page,

[not at google - send to devlin, 2015/03/16 17:39:55]

This flag is actually a bit confusing. I don't know whether "extensions page" in
this context means "a page in an extension" or "chrome://extensions" -- the
latter, I presume? But from_webui might be better.

[Devlin, 2015/03/16 21:10:55]

The reason I said from_extensions_page was to match the AppInfoLaunchSource enum
below.  But it's probably safe to say that the only webui calling this will be
the chrome extensions page, at least for now.

+                   const base::Closure& on_complete);
+
+ private:
+  ShowPermissionsDialogHelper(Profile* profile,
+                              const base::Closure& on_complete);
+  ~ShowPermissionsDialogHelper() override;  // Manages its own lifetime.
+
+  // Shows the old-style (not AppInfo) permissions dialog.
+  void ShowPermissionsDialog(content::WebContents* web_contents,
+                             const Extension* extension);
+
+  // ExtensionInstallPrompt::Delegate:
+  void InstallUIProceed() override;
+  void InstallUIAbort(bool user_initiated) override;
+
+  scoped_ptr<ExtensionInstallPrompt> prompt_;
+
+  Profile* profile_;
+
+  base::Closure on_complete_;
+
+  std::string extension_id_;
+
+  DISALLOW_COPY_AND_ASSIGN(ShowPermissionsDialogHelper);
+};
+
+}  // namespace extensions
+
+#endif  // CHROME_BROWSER_EXTENSIONS_API_DEVELOPER_PRIVATE_SHOW_PERMISSIONS_DIALOG_HELPER_H_