Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issue 1008933002: Don't assert that we only cross compile on linux (Closed)

Created:
5 years, 9 months ago by jochen (gone - plz use gerrit)
Modified:
5 years, 9 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Don't assert that we only cross compile on linux We also cross compile on Windows for example. Since we can't switch the toolchain there, we'll just use the 64bit toolchain and produce an invalid snapshot :-/ BUG=none R=dpranke@chromium.org LOG=n TBR=machenbach@chromium.org Committed: https://crrev.com/52cf2e8b8aaef826050cd15921eea9a21a9a6ae0 Cr-Commit-Position: refs/heads/master@{#27192}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M BUILD.gn View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
jochen (gone - plz use gerrit)
5 years, 9 months ago (2015-03-13 18:53:39 UTC) #1
Dirk Pranke
I think this is at least slightly more right, though I need to keep thinking ...
5 years, 9 months ago (2015-03-13 19:48:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1008933002/1
5 years, 9 months ago (2015-03-13 19:49:06 UTC) #4
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 9 months ago (2015-03-13 19:49:08 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1008933002/1
5 years, 9 months ago (2015-03-13 20:27:55 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-13 20:49:48 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/52cf2e8b8aaef826050cd15921eea9a21a9a6ae0 Cr-Commit-Position: refs/heads/master@{#27192}
5 years, 9 months ago (2015-03-13 20:49:59 UTC) #10
Michael Achenbach
5 years, 9 months ago (2015-03-13 21:42:07 UTC) #12
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698