Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Issue 1008923004: [turbofan] Turn weaken min/max limits for typer into constants. (Closed)

Created:
5 years, 9 months ago by Benedikt Meurer
Modified:
5 years, 9 months ago
Reviewers:
Jarin
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Turn weaken min/max limits for typer into constants. The weaken limits are constants, there's no point in having a separate copy of those constants per typer that is initialized per Typer instance. R=jarin@chromium.org Committed: https://crrev.com/a9da8a333af28525e3a944ed34c8f58a6bcced48 Cr-Commit-Position: refs/heads/master@{#27297}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -26 lines) Patch
M src/compiler/typer.h View 2 chunks +0 lines, -3 lines 0 comments Download
M src/compiler/typer.cc View 5 chunks +23 lines, -23 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Benedikt Meurer
5 years, 9 months ago (2015-03-19 10:28:36 UTC) #1
Benedikt Meurer
PTAL
5 years, 9 months ago (2015-03-19 10:28:50 UTC) #2
Jarin
lgtm
5 years, 9 months ago (2015-03-19 11:33:57 UTC) #3
commit-bot: I haz the power
5 years, 9 months ago (2015-03-19 11:46:11 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a9da8a333af28525e3a944ed34c8f58a6bcced48
Cr-Commit-Position: refs/heads/master@{#27297}

Powered by Google App Engine
This is Rietveld 408576698