Serializer: micro-optimizations for the deserializer.

Serializer: micro-optimizations for the deserializer.

R=vogelheim@chromium.org

Committed: https://crrev.com/773f297738aa72f422126415be8070eb25edd603
Cr-Commit-Position: refs/heads/master@{#27230}

[vogelheim, 2015-03-16 15:23:08]

lgtm

(only a nitpick & a clarifying question)

https://codereview.chromium.org/1008923003/diff/1/src/snapshot-source-sink.h
File src/snapshot-source-sink.h (right):

https://codereview.chromium.org/1008923003/diff/1/src/snapshot-source-sink.h#...
src/snapshot-source-sink.h:45: // suffer from branch mispredictions.
The DCHECK for exceeding the buffer is gone. Was that intentional?

https://codereview.chromium.org/1008923003/diff/1/src/snapshot-source-sink.h#...
src/snapshot-source-sink.h:45: // suffer from branch mispredictions.
Any idea why the compiler didn't inline GetUnalignedInt?

[Yang, 2015-03-17 08:59:11]

On 2015/03/16 15:23:08, vogelheim wrote:
> lgtm
> 
> (only a nitpick & a clarifying question)
> 
> https://codereview.chromium.org/1008923003/diff/1/src/snapshot-source-sink.h
> File src/snapshot-source-sink.h (right):
> 
>
https://codereview.chromium.org/1008923003/diff/1/src/snapshot-source-sink.h#...
> src/snapshot-source-sink.h:45: // suffer from branch mispredictions.
> The DCHECK for exceeding the buffer is gone. Was that intentional?
> 
>
https://codereview.chromium.org/1008923003/diff/1/src/snapshot-source-sink.h#...
> src/snapshot-source-sink.h:45: // suffer from branch mispredictions.
> Any idea why the compiler didn't inline GetUnalignedInt?

You are right. I re-added and fixed the assertion (it was not checking the right
thing before). I think it did not inline because GetUnalignedInt is implemented
in a .cc file, which is a separate compilation unit than its callers.

[Yang, 2015-03-17 08:59:14]

The CQ bit was checked by yangguo@chromium.org

[Yang, 2015-03-17 08:59:14]

The patchset sent to the CQ was uploaded after l-g-t-m from
vogelheim@chromium.org
Link to the patchset: https://codereview.chromium.org/1008923003/#ps20001
(title: "add assertion")

[commit-bot: I haz the power, 2015-03-17 08:59:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1008923003/20001

[commit-bot: I haz the power, 2015-03-17 09:23:39]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-03-17 09:23:49]

Patchset 2 (id:??) landed as
https://crrev.com/773f297738aa72f422126415be8070eb25edd603
Cr-Commit-Position: refs/heads/master@{#27230}