Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2017)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: content/test/test_web_contents.cc

Issue 1008913002: Remove RenderViewHost parameter from WebContentsObserver::Did{Start|Stop}Loading. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« content/browser/web_contents/web_contents_impl.cc ('K') | « content/public/test/test_navigation_observer.cc ('k') | extensions/browser/extension_host.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/test/test_web_contents.cc
diff --git a/content/test/test_web_contents.cc b/content/test/test_web_contents.cc
index d3f47f6d60767a8b6b4aa7cb5084b24a0f1445c5..afb833040878fbb08fd5d8154b351aed6a8cc859 100644
--- a/content/test/test_web_contents.cc
+++ b/content/test/test_web_contents.cc
@@ -139,7 +139,7 @@ void TestWebContents::NavigateAndCommit(const GURL& url) {
}
void TestWebContents::TestSetIsLoading(bool value) {
- SetIsLoading(GetRenderViewHost(), value, true, NULL);
+ SetIsLoading(value, true, NULL);
nasko 2015/03/14 00:01:04 nit: nullptr
Fabrice (no longer in Chrome) 2015/03/16 11:01:46 Done.
}
void TestWebContents::CommitPendingNavigation() {
« content/browser/web_contents/web_contents_impl.cc ('K') | « content/public/test/test_navigation_observer.cc ('k') | extensions/browser/extension_host.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698