content/public/test/browser_test_utils.h - Issue 1008913002: Remove RenderViewHost parameter from WebContentsObserver::Did{Start|Stop}Loading.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/test/browser_test_utils.h

Issue 1008913002: Remove RenderViewHost parameter from WebContentsObserver::Did{Start|Stop}Loading. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/web_contents/web_contents_impl.cc ('K') | « content/public/browser/web_contents_observer.h ('k') | content/public/test/browser_test_utils.cc » ('j') | content/test/test_web_contents.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/test/browser_test_utils.h

diff --git a/content/public/test/browser_test_utils.h b/content/public/test/browser_test_utils.h

index 175becbd226e351dafffe003d49933f1a1f70dc3..cf1220d6783d0ae054caa5229ec7eae9c0059b29 100644

--- a/content/public/test/browser_test_utils.h

+++ b/content/public/test/browser_test_utils.h

@@ -270,7 +270,7 @@ class TitleWatcher : public WebContentsObserver {

private:

// Overridden WebContentsObserver methods.

- void DidStopLoading(RenderViewHost* render_view_host) override;

+ void DidStopLoading() override;

void TitleWasSet(NavigationEntry* entry, bool explicit_set) override;

void TestTitle();