content/browser/web_contents/web_contents_impl_unittest.cc - Issue 1008913002: Remove RenderViewHost parameter from WebContentsObserver::Did{Start|Stop}Loading.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/web_contents_impl_unittest.cc

Issue 1008913002: Remove RenderViewHost parameter from WebContentsObserver::Did{Start|Stop}Loading. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/web_contents/web_contents_impl.cc ('K') | « content/browser/web_contents/web_contents_impl_browsertest.cc ('k') | content/public/browser/web_contents_observer.h » ('j') | content/test/test_web_contents.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/web_contents/web_contents_impl_unittest.cc

diff --git a/content/browser/web_contents/web_contents_impl_unittest.cc b/content/browser/web_contents/web_contents_impl_unittest.cc

index dfba4445ce83e7aaca117e2f6ce2bbef99f9b330..c8b2fc70b3edae3d802e051a2d6141529a4253b3 100644

--- a/content/browser/web_contents/web_contents_impl_unittest.cc

+++ b/content/browser/web_contents/web_contents_impl_unittest.cc

@@ -2764,12 +2764,8 @@ class LoadingWebContentsObserver : public WebContentsObserver {

}

~LoadingWebContentsObserver() override {}

- void DidStartLoading(RenderViewHost* rvh) override {

- is_loading_ = true;

- }

- void DidStopLoading(RenderViewHost* rvh) override {

- is_loading_ = false;

- }

+ void DidStartLoading() override { is_loading_ = true; }

+ void DidStopLoading() override { is_loading_ = false; }

bool is_loading() const { return is_loading_; }