Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7440)

Unified Diff: chrome/browser/tab_contents/navigation_metrics_recorder.cc

Issue 1008913002: Remove RenderViewHost parameter from WebContentsObserver::Did{Start|Stop}Loading. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/tab_contents/navigation_metrics_recorder.cc
diff --git a/chrome/browser/tab_contents/navigation_metrics_recorder.cc b/chrome/browser/tab_contents/navigation_metrics_recorder.cc
index 5e9149f3004b920ff60cc5db08504b8b7f33496d..1be27f0b9b0b922e2b9aee20bf5683103c8b31ff 100644
--- a/chrome/browser/tab_contents/navigation_metrics_recorder.cc
+++ b/chrome/browser/tab_contents/navigation_metrics_recorder.cc
@@ -33,11 +33,12 @@ void NavigationMetricsRecorder::DidNavigateMainFrame(
details.is_in_page);
}
-void NavigationMetricsRecorder::DidStartLoading(
- content::RenderViewHost* render_view_host) {
+void NavigationMetricsRecorder::DidStartLoading() {
#if defined(OS_WIN) && defined(USE_ASH)
- if (render_view_host && base::win::GetVersion() >= base::win::VERSION_WIN8) {
- content::RenderWidgetHostView* rwhv = render_view_host->GetView();
+ content::RenderViewHost* rvh = web_contents()->GetRenderViewHost();
+
+ if (rvh && base::win::GetVersion() >= base::win::VERSION_WIN8) {
+ content::RenderWidgetHostView* rwhv = rvh->GetView();
if (rwhv) {
gfx::NativeView native_view = rwhv->GetNativeView();
if (native_view) {
@@ -51,5 +52,3 @@ void NavigationMetricsRecorder::DidStartLoading(
}
#endif
}
-
-
« no previous file with comments | « chrome/browser/tab_contents/navigation_metrics_recorder.h ('k') | chrome/browser/thumbnails/thumbnail_tab_helper.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698