content/browser/frame_host/navigation_controller_delegate.h - Issue 1008913002: Remove RenderViewHost parameter from WebContentsObserver::Did{Start|Stop}Loading.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/browser/frame_host/navigation_controller_delegate.h

Issue 1008913002: Remove RenderViewHost parameter from WebContentsObserver::Did{Start|Stop}Loading. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix Android + Review comments Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « content/browser/frame_host/interstitial_page_impl.cc ('k') | content/browser/frame_host/navigation_controller_impl_browsertest.cc » ('j') | extensions/browser/guest_view/guest_view_base.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2013 The Chromium Authors. All rights reserved.	1 // Copyright 2013 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CONTENT_BROWSER_FRAME_HOST_NAVIGATION_CONTROLLER_DELEGATE_H_	5 #ifndef CONTENT_BROWSER_FRAME_HOST_NAVIGATION_CONTROLLER_DELEGATE_H_

6 #define CONTENT_BROWSER_FRAME_HOST_NAVIGATION_CONTROLLER_DELEGATE_H_	6 #define CONTENT_BROWSER_FRAME_HOST_NAVIGATION_CONTROLLER_DELEGATE_H_

7	7

8 #include <string>	8 #include <string>

9 #include "content/public/browser/invalidate_type.h"	9 #include "content/public/browser/invalidate_type.h"

10 #include "content/public/browser/navigation_controller.h"	10 #include "content/public/browser/navigation_controller.h"

(...skipping 53 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
64 // embedder for NavigationController will be a WebContents object.	64 // embedder for NavigationController will be a WebContents object.

65 virtual WebContents* GetWebContents() = 0;	65 virtual WebContents* GetWebContents() = 0;

66	66

67 // Methods needed by InterstitialPageImpl.	67 // Methods needed by InterstitialPageImpl.

68 virtual bool IsHidden() = 0;	68 virtual bool IsHidden() = 0;

69 virtual void RenderFrameForInterstitialPageCreated(	69 virtual void RenderFrameForInterstitialPageCreated(

70 RenderFrameHost* render_frame_host) = 0;	70 RenderFrameHost* render_frame_host) = 0;

71 virtual void AttachInterstitialPage(	71 virtual void AttachInterstitialPage(

72 InterstitialPageImpl* interstitial_page) = 0;	72 InterstitialPageImpl* interstitial_page) = 0;

73 virtual void DetachInterstitialPage() = 0;	73 virtual void DetachInterstitialPage() = 0;

74 virtual void SetIsLoading(RenderViewHost* render_view_host,	74 virtual void SetIsLoading(bool is_loading,

75 bool is_loading,

76 bool to_different_document,	75 bool to_different_document,

77 LoadNotificationDetails* details) = 0;	76 LoadNotificationDetails* details) = 0;

78 };	77 };

79	78

80 } // namespace content	79 } // namespace content

81	80

82 #endif // CONTENT_BROWSER_FRAME_HOST_NAVIGATION_CONTROLLER_DELEGATE_H_	81 #endif // CONTENT_BROWSER_FRAME_HOST_NAVIGATION_CONTROLLER_DELEGATE_H_

OLD	NEW