Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Side by Side Diff: chrome/browser/captive_portal/captive_portal_tab_helper.h

Issue 1008913002: Remove RenderViewHost parameter from WebContentsObserver::Did{Start|Stop}Loading. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix Android + Review comments Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_CAPTIVE_PORTAL_CAPTIVE_PORTAL_TAB_HELPER_H_ 5 #ifndef CHROME_BROWSER_CAPTIVE_PORTAL_CAPTIVE_PORTAL_TAB_HELPER_H_
6 #define CHROME_BROWSER_CAPTIVE_PORTAL_CAPTIVE_PORTAL_TAB_HELPER_H_ 6 #define CHROME_BROWSER_CAPTIVE_PORTAL_CAPTIVE_PORTAL_TAB_HELPER_H_
7 7
8 #include "base/basictypes.h" 8 #include "base/basictypes.h"
9 #include "base/compiler_specific.h" 9 #include "base/compiler_specific.h"
10 #include "base/memory/scoped_ptr.h" 10 #include "base/memory/scoped_ptr.h"
(...skipping 63 matching lines...) Expand 10 before | Expand all | Expand 10 after
74 void DidCommitProvisionalLoadForFrame( 74 void DidCommitProvisionalLoadForFrame(
75 content::RenderFrameHost* render_frame_host, 75 content::RenderFrameHost* render_frame_host,
76 const GURL& url, 76 const GURL& url,
77 ui::PageTransition transition_type) override; 77 ui::PageTransition transition_type) override;
78 78
79 void DidFailProvisionalLoad(content::RenderFrameHost* render_frame_host, 79 void DidFailProvisionalLoad(content::RenderFrameHost* render_frame_host,
80 const GURL& validated_url, 80 const GURL& validated_url,
81 int error_code, 81 int error_code,
82 const base::string16& error_description) override; 82 const base::string16& error_description) override;
83 83
84 void DidStopLoading(content::RenderViewHost* render_view_host) override; 84 void DidStopLoading() override;
85 85
86 // content::NotificationObserver: 86 // content::NotificationObserver:
87 void Observe(int type, 87 void Observe(int type,
88 const content::NotificationSource& source, 88 const content::NotificationSource& source,
89 const content::NotificationDetails& details) override; 89 const content::NotificationDetails& details) override;
90 90
91 // Called when a certificate interstitial error page is about to be shown. 91 // Called when a certificate interstitial error page is about to be shown.
92 void OnSSLCertError(const net::SSLInfo& ssl_info); 92 void OnSSLCertError(const net::SSLInfo& ssl_info);
93 93
94 // A "Login Tab" is a tab that was originally at a captive portal login 94 // A "Login Tab" is a tab that was originally at a captive portal login
(...skipping 54 matching lines...) Expand 10 before | Expand all | Expand 10 after
149 // cross-process navitations. NULL when there's currently no provisional 149 // cross-process navitations. NULL when there's currently no provisional
150 // load. 150 // load.
151 content::RenderViewHost* provisional_render_view_host_; 151 content::RenderViewHost* provisional_render_view_host_;
152 152
153 content::NotificationRegistrar registrar_; 153 content::NotificationRegistrar registrar_;
154 154
155 DISALLOW_COPY_AND_ASSIGN(CaptivePortalTabHelper); 155 DISALLOW_COPY_AND_ASSIGN(CaptivePortalTabHelper);
156 }; 156 };
157 157
158 #endif // CHROME_BROWSER_CAPTIVE_PORTAL_CAPTIVE_PORTAL_TAB_HELPER_H_ 158 #endif // CHROME_BROWSER_CAPTIVE_PORTAL_CAPTIVE_PORTAL_TAB_HELPER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698