Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 1008883002: Handle paths that do not report empty, but have no edges. (Closed)

Created:
5 years, 9 months ago by reed1
Modified:
5 years, 9 months ago
Reviewers:
caryclark
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Handle paths that do not report empty, but have no edges. patch from issue 999963005 at patchset 1 (http://crrev.com/999963005#ps1) BUG=skia:3527 Committed: https://skia.googlesource.com/skia/+/c1b11f1db69bea8d64ebf656ae92ea9ec6dbb40f

Patch Set 1 #

Patch Set 2 : add canvas test #

Patch Set 3 : use helper function instead of goto #

Patch Set 4 : fix uninit warning? #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -13 lines) Patch
M src/core/SkRegion_path.cpp View 1 2 3 3 chunks +22 lines, -13 lines 0 comments Download
M tests/CanvasTest.cpp View 1 1 chunk +16 lines, -0 lines 0 comments Download
M tests/RegionTest.cpp View 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (6 generated)
reed1
ptal
5 years, 9 months ago (2015-03-13 15:05:12 UTC) #2
reed1
added canvas test
5 years, 9 months ago (2015-03-13 15:13:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1008883002/20001
5 years, 9 months ago (2015-03-13 15:13:35 UTC) #5
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 9 months ago (2015-03-13 15:13:37 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: Build-Ubuntu13.10-GCC4.8-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu13.10-GCC4.8-x86_64-Release-Trybot/builds/2492)
5 years, 9 months ago (2015-03-13 15:14:51 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1008883002/40001
5 years, 9 months ago (2015-03-13 15:21:39 UTC) #10
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 9 months ago (2015-03-13 15:21:40 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: Build-Ubuntu13.10-GCC4.8-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu13.10-GCC4.8-x86_64-Release-Trybot/builds/2494)
5 years, 9 months ago (2015-03-13 15:22:54 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1008883002/60001
5 years, 9 months ago (2015-03-13 15:29:05 UTC) #15
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 9 months ago (2015-03-13 15:29:06 UTC) #16
caryclark
lgtm
5 years, 9 months ago (2015-03-13 15:48:06 UTC) #17
commit-bot: I haz the power
5 years, 9 months ago (2015-03-13 15:48:31 UTC) #18
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/c1b11f1db69bea8d64ebf656ae92ea9ec6dbb40f

Powered by Google App Engine
This is Rietveld 408576698