Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 1008833003: Enable always-on hotwording hardware check on unstable channels only. (Closed)

Created:
5 years, 9 months ago by Anand Mistry (off Chromium)
Modified:
5 years, 9 months ago
Reviewers:
Lei Zhang, kcarattini
CC:
chromium-reviews, skanuj+watch_chromium.org, melevin+watch_chromium.org, dhollowa+watch_chromium.org, dougw+watch_chromium.org, donnd+watch_chromium.org, jfweitz+watch_chromium.org, David Black, samarth+watch_chromium.org, kmadhusu+watch_chromium.org, rlp+watch_chromium.org, Jered
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable always-on hotwording hardware check on unstable channels only. All others have the check disabled, and need to override with a flag. Committed: https://crrev.com/33eefa50e855608454ddf92fd09b418c3b5dac98 Cr-Commit-Position: refs/heads/master@{#320856}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -5 lines) Patch
M chrome/browser/search/hotword_service_factory.cc View 1 3 chunks +6 lines, -5 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
Anand Mistry (off Chromium)
thestig: As you suggested in a previous change.
5 years, 9 months ago (2015-03-16 22:49:07 UTC) #2
Lei Zhang
lgtm Make the newly added code its own function if you feel that's cleaner.
5 years, 9 months ago (2015-03-16 23:00:03 UTC) #3
kcarattini
lgtm
5 years, 9 months ago (2015-03-16 23:22:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1008833003/1
5 years, 9 months ago (2015-03-17 00:20:10 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/5897) ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 9 months ago (2015-03-17 00:23:57 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1008833003/20001
5 years, 9 months ago (2015-03-17 02:07:16 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-17 03:24:17 UTC) #12
commit-bot: I haz the power
5 years, 9 months ago (2015-03-17 03:25:08 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/33eefa50e855608454ddf92fd09b418c3b5dac98
Cr-Commit-Position: refs/heads/master@{#320856}

Powered by Google App Engine
This is Rietveld 408576698