Issue 100883004: ConflictResolver: fix reversed should_success check

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 100883004: ConflictResolver: fix reversed should_success check (Closed)

Created:
7 years ago by kinuko

Modified:
7 years ago

Reviewers:
tzik

CC:
chromium-reviews, kinuko+watch, nhiroki, tzik

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

ConflictResolver: fix reversed should_success check Looks like this should be likely fixed too? BUG=240165 R=tzik@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238310

Created: 7 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	chrome/browser/sync_file_system/drive_backend/conflict_resolver.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 4 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinuko@chromium.org/100883004/1

7 years ago (2013-12-03 03:48:59 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r238310.