Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1393)

Issue 1008823002: Encode RelocInfo extra tag to fit changed RelocInfo kind enum. (Closed)

Created:
5 years, 9 months ago by Yang
Modified:
5 years, 9 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Encode RelocInfo extra tag to fit changed RelocInfo kind enum. This fixes some failures on MIPS. Though not all of them, since MIPS does not correctly implement set_target_internal_reference. R=svenpanne@chromium.org Committed: https://crrev.com/cc2c902fa5d032c87d28e82a7422dfd31361ca73 Cr-Commit-Position: refs/heads/master@{#27183}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/assembler.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Yang
5 years, 9 months ago (2015-03-13 12:57:01 UTC) #1
Sven Panne
lgtm
5 years, 9 months ago (2015-03-13 13:00:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1008823002/1
5 years, 9 months ago (2015-03-13 13:00:45 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-13 13:39:24 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/cc2c902fa5d032c87d28e82a7422dfd31361ca73 Cr-Commit-Position: refs/heads/master@{#27183}
5 years, 9 months ago (2015-03-13 13:39:35 UTC) #6
MTBrandyberry
5 years, 9 months ago (2015-03-13 13:56:44 UTC) #7
Message was sent while issue was closed.
On 2015/03/13 12:57:01, Yang wrote:

Thanks for implementing the recommended changes.  One question:

Shouldn't LAST_STANDARD_NONCOMPACT_ENUM now be INTERNAL_REFERENCE_ENCODED?

Powered by Google App Engine
This is Rietveld 408576698