Oilpan: trace non-owned InspectorOverlay references.

Oilpan: trace non-owned InspectorOverlay references.

The agent objects keeping a reference to their controlling object's
InspectorOverlay should trace the reference, as InspectorOverlay is now
on the heap.

R=haraken
BUG=340522
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191844

[sof, 2015-03-13 12:34:55]

sigbjornf@opera.com changed reviewers:
+ oilpan-reviews@chromium.org

[sof, 2015-03-13 12:34:56]

please take a look.

[haraken, 2015-03-13 12:38:40]

haraken@chromium.org changed reviewers:
+ haraken@chromium.org

[haraken, 2015-03-13 12:38:40]

LGTM

https://codereview.chromium.org/1008813002/diff/1/Source/core/inspector/Inspe...
File Source/core/inspector/InspectorPageAgent.h (right):

https://codereview.chromium.org/1008813002/diff/1/Source/core/inspector/Inspe...
Source/core/inspector/InspectorPageAgent.h:221: HashMap<String, LocalFrame*>
m_identifierToFrame;

Can these LocalFrames be Members?

BTW, can the plugin detect these raw pointers in HashMaps, Vectors etc?

[sof, 2015-03-13 12:45:04]

https://codereview.chromium.org/1008813002/diff/1/Source/core/inspector/Inspe...
File Source/core/inspector/InspectorPageAgent.h (right):

https://codereview.chromium.org/1008813002/diff/1/Source/core/inspector/Inspe...
Source/core/inspector/InspectorPageAgent.h:221: HashMap<String, LocalFrame*>
m_identifierToFrame;
On 2015/03/13 12:38:40, haraken wrote:
> 
> Can these LocalFrames be Members?
> 
> BTW, can the plugin detect these raw pointers in HashMaps, Vectors etc?

It might be possible, I forget if this is one of the maps we had problems moving
earlier to the heap.

The GC plugin detects raw&unsafe pointers from collection objects.

[sof, 2015-03-13 12:55:19]

The CQ bit was checked by sigbjornf@opera.com

[commit-bot: I haz the power, 2015-03-13 12:55:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1008813002/1

[commit-bot: I haz the power, 2015-03-13 14:38:52]

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=191844