Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 1008813002: Oilpan: trace non-owned InspectorOverlay references. (Closed)

Created:
5 years, 9 months ago by sof
Modified:
5 years, 9 months ago
Reviewers:
oilpan-reviews, haraken
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Oilpan: trace non-owned InspectorOverlay references. The agent objects keeping a reference to their controlling object's InspectorOverlay should trace the reference, as InspectorOverlay is now on the heap. R=haraken BUG=340522 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191844

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -7 lines) Patch
M Source/core/inspector/InspectorDOMAgent.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorDOMAgent.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/inspector/InspectorPageAgent.h View 1 chunk +1 line, -1 line 2 comments Download
M Source/core/inspector/InspectorPageAgent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorProfilerAgent.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorProfilerAgent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/PageDebuggerAgent.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/PageDebuggerAgent.cpp View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
sof
please take a look.
5 years, 9 months ago (2015-03-13 12:34:56 UTC) #2
haraken
LGTM https://codereview.chromium.org/1008813002/diff/1/Source/core/inspector/InspectorPageAgent.h File Source/core/inspector/InspectorPageAgent.h (right): https://codereview.chromium.org/1008813002/diff/1/Source/core/inspector/InspectorPageAgent.h#newcode221 Source/core/inspector/InspectorPageAgent.h:221: HashMap<String, LocalFrame*> m_identifierToFrame; Can these LocalFrames be Members? ...
5 years, 9 months ago (2015-03-13 12:38:40 UTC) #4
sof
https://codereview.chromium.org/1008813002/diff/1/Source/core/inspector/InspectorPageAgent.h File Source/core/inspector/InspectorPageAgent.h (right): https://codereview.chromium.org/1008813002/diff/1/Source/core/inspector/InspectorPageAgent.h#newcode221 Source/core/inspector/InspectorPageAgent.h:221: HashMap<String, LocalFrame*> m_identifierToFrame; On 2015/03/13 12:38:40, haraken wrote: > ...
5 years, 9 months ago (2015-03-13 12:45:04 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1008813002/1
5 years, 9 months ago (2015-03-13 12:55:33 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-13 14:38:52 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=191844

Powered by Google App Engine
This is Rietveld 408576698