Would you mind verifying some images that appear blank in the side-by-side
diffs? I know binary changes aren't reliable for diff viewing, but all the
others show okay and I know we've tweaked the optimization lately, so I want to
make sure these are okay too:
.../default_100_percent/common/toolbar_button_hover_top_right.png
.../default_200_percent/common/chip_extended_validation_top_left.png
.../default_200_percent/common/chip_malware_top_right.png
.../default_200_percent/common/controlled_setting_extension.png
.../default_200_percent/common/login_guest.png
.../default_200_percent/common/toolbar_button_hover_right.png
.../default_200_percent/common/toolbar_button_hover_top_left.png
.../default_200_percent/common/toolbar_button_pressed_center.png
.../default_200_percent/common/toolbar_button_pressed_left.png
LGTM if the files appear correct for you locally.
oshima
On 2013/12/17 01:32:13, msw wrote: > Would you mind verifying some images that appear blank ...
On 2013/12/17 01:32:13, msw wrote:
> Would you mind verifying some images that appear blank in the side-by-side
> diffs? I know binary changes aren't reliable for diff viewing, but all the
> others show okay and I know we've tweaked the optimization lately, so I want
to
> make sure these are okay too:
>
> .../default_100_percent/common/toolbar_button_hover_top_right.png
>
> .../default_200_percent/common/chip_extended_validation_top_left.png
> .../default_200_percent/common/chip_malware_top_right.png
> .../default_200_percent/common/controlled_setting_extension.png
> .../default_200_percent/common/login_guest.png
> .../default_200_percent/common/toolbar_button_hover_right.png
> .../default_200_percent/common/toolbar_button_hover_top_left.png
> .../default_200_percent/common/toolbar_button_pressed_center.png
> .../default_200_percent/common/toolbar_button_pressed_left.png
>
> LGTM if the files appear correct for you locally.
Yes, these files look ok with gimp.
oshima
Committed patchset #1 manually as r241097 (presubmit successful).
Issue 100873004: Optimize png files in chrome/app/theme
(Closed)
Created 7 years ago by oshima
Modified 7 years ago
Reviewers: msw
Base URL: svn://svn.chromium.org/chrome/trunk/src
Comments: 0