Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 1008723006: Remove HTTP cache Record/Playback support (Closed)

Created:
5 years, 9 months ago by rvargas (doing something else)
Modified:
5 years, 9 months ago
Reviewers:
Nico
CC:
chromium-reviews, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, timurrrr+watch_chromium.org, chromium-apps-reviews_chromium.org, erikwright+watch_chromium.org, glider+watch_chromium.org, bruening+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove HTTP cache Record/Playback support This removes the ability to save and replay browsing sessions to/from the cache. BUG=469256 Committed: https://crrev.com/06681dfba5c89956f650aea3767c08d41f22bac1 Cr-Commit-Position: refs/heads/master@{#321643}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -262 lines) Patch
M chrome/browser/chrome_content_browser_client.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/net/cookie_store_util.h View 1 chunk +0 lines, -8 lines 0 comments Download
M chrome/browser/net/cookie_store_util.cc View 1 chunk +0 lines, -16 lines 0 comments Download
M chrome/browser/profiles/profile_impl_io_data.cc View 3 chunks +0 lines, -28 lines 0 comments Download
M chrome/browser/ui/browser_window_state.cc View 1 chunk +0 lines, -11 lines 0 comments Download
M chrome/chrome_renderer.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/common/chrome_constants.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/common/chrome_constants.cc View 1 chunk +0 lines, -12 lines 0 comments Download
M chrome/common/chrome_switches.h View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/common/chrome_switches.cc View 2 chunks +0 lines, -10 lines 0 comments Download
M chrome/renderer/chrome_content_renderer_client.cc View 2 chunks +0 lines, -6 lines 0 comments Download
D chrome/renderer/playback_extension.h View 1 chunk +0 lines, -32 lines 0 comments Download
D chrome/renderer/playback_extension.cc View 1 chunk +0 lines, -48 lines 0 comments Download
M net/http/http_cache.h View 1 chunk +0 lines, -5 lines 0 comments Download
M net/http/http_cache.cc View 1 chunk +9 lines, -32 lines 0 comments Download
M net/http/http_cache_transaction.cc View 6 chunks +14 lines, -44 lines 0 comments Download
M tools/valgrind/gtest_exclude/browser_tests.gtest-memcheck.txt View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
rvargas (doing something else)
5 years, 9 months ago (2015-03-20 21:14:38 UTC) #5
Nico
lgtm Say "disk cache" (or at least "cache") somewhere in the cl description, as-is it ...
5 years, 9 months ago (2015-03-20 21:27:20 UTC) #6
rvargas (doing something else)
On 2015/03/20 21:27:20, Nico wrote: > lgtm > > Say "disk cache" (or at least ...
5 years, 9 months ago (2015-03-20 21:50:50 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1008723006/60001
5 years, 9 months ago (2015-03-20 21:51:41 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:60001)
5 years, 9 months ago (2015-03-20 21:57:38 UTC) #10
commit-bot: I haz the power
5 years, 9 months ago (2015-03-20 21:58:26 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/06681dfba5c89956f650aea3767c08d41f22bac1
Cr-Commit-Position: refs/heads/master@{#321643}

Powered by Google App Engine
This is Rietveld 408576698