Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Issue 1008693005: PNaCl: Update LLVM revision in pnacl/COMPONENT_REVISIONS (Closed)

Created:
5 years, 9 months ago by JF
Modified:
5 years, 9 months ago
Reviewers:
Derek Schuff
CC:
native-client-reviews_googlegroups.com, JF, Jim Stichnoth
Base URL:
https://chromium.googlesource.com/native_client/src/native_client.git@master
Target Ref:
refs/heads/master
Project:
nacl
Visibility:
Public.

Description

PNaCl: Update LLVM revision in pnacl/COMPONENT_REVISIONS This pulls in the following LLVM changes: 899d5ab: (stichnot@chromium.org) Allow the LLVM cmake build to use ccache. c5f8056: (jfb@chromium.org) ExpandVarArgs: don't pack the vararg struct BUG= https://code.google.com/p/nativeclient/issues/detail?id=4102 TEST= PNaCl toolchain trybots TBR= dschuff@chromium.org Committed: https://chromium.googlesource.com/native_client/src/native_client/+/84b4c32e4b53a143a8599d26df25a4d5d996c825

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M pnacl/COMPONENT_REVISIONS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1008693005/1
5 years, 9 months ago (2015-03-13 21:37:11 UTC) #2
commit-bot: I haz the power
Try jobs failed on following builders: nacl-arm_opt_panda on tryserver.nacl (JOB_TIMED_OUT, http://build.chromium.org/p/tryserver.nacl/builders/nacl-arm_opt_panda/builds/9457) Timed out jobs are ...
5 years, 9 months ago (2015-03-14 03:37:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1008693005/1
5 years, 9 months ago (2015-03-14 05:36:56 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/native_client/src/native_client/+/84b4c32e4b53a143a8599d26df25a4d5d996c825
5 years, 9 months ago (2015-03-14 09:23:55 UTC) #7
JF
5 years, 9 months ago (2015-03-14 15:17:59 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1002423002/ by jfb@chromium.org.

The reason for reverting is: This causes a bunch of failures on the PNaCl
toolchain waterfall, which seem related to reading bad data from the stack.
Reverting..

Powered by Google App Engine
This is Rietveld 408576698