Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1281)

Unified Diff: content/renderer/scheduler/task_queue_manager.h

Issue 1008693004: Handle delayed tasks more natively in the scheduler (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Sami's Suggestions Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/scheduler/task_queue_manager.h
diff --git a/content/renderer/scheduler/task_queue_manager.h b/content/renderer/scheduler/task_queue_manager.h
index 5859a5291b53f078cd90168d0d4e9ff0b848802c..4e2bee0ad121cc5a60273cf8c34b5fd996d677c4 100644
--- a/content/renderer/scheduler/task_queue_manager.h
+++ b/content/renderer/scheduler/task_queue_manager.h
@@ -29,6 +29,7 @@ class TestNowSource;
namespace content {
namespace internal {
+class LazyNow;
class TaskQueue;
}
class TaskQueueSelector;
@@ -116,6 +117,7 @@ class CONTENT_EXPORT TaskQueueManager {
void SetTimeSourceForTesting(scoped_refptr<cc::TestNowSource> time_source);
private:
+ friend class internal::LazyNow;
friend class internal::TaskQueue;
// Called by the task queue to register a new pending task and allocate a
@@ -130,14 +132,14 @@ class CONTENT_EXPORT TaskQueueManager {
// Use the selector to choose a pending task and run it.
void DoWork(bool posted_from_main_thread);
+ // Delayed Tasks with run_times <= Now() are enqueued onto their work queues.
// Reloads any empty work queues which have automatic pumping enabled and
// which are eligible to be auto pumped based on the |previous_task| which was
// run. Call with an empty |previous_task| if no task was just run. Returns
// true if any work queue has tasks after doing this.
// |next_pending_delayed_task| should be the time of the next known delayed
// task. It is updated if any task is found which should run earlier.
- bool UpdateWorkQueues(base::TimeTicks* next_pending_delayed_task,
- const base::PendingTask* previous_task);
+ bool UpdateWorkQueues(const base::PendingTask* previous_task);
// Chooses the next work queue to service. Returns true if |out_queue_index|
// indicates the queue from which the next task should be run, false to

Powered by Google App Engine
This is Rietveld 408576698