Handle delayed tasks more natively in the scheduler

content/renderer/scheduler/task_queue_manager_unittest.cc

Index: content/renderer/scheduler/task_queue_manager_unittest.cc
diff --git a/content/renderer/scheduler/task_queue_manager_unittest.cc b/content/renderer/scheduler/task_queue_manager_unittest.cc
index 845e9bad2c4e7e1bdb27d819b1c20774483338db..852a12e681edd2613e4c15351013245b0bfdf692 100644
--- a/content/renderer/scheduler/task_queue_manager_unittest.cc
+++ b/content/renderer/scheduler/task_queue_manager_unittest.cc
@@ -4,8 +4,8 @@
 
 #include "content/renderer/scheduler/task_queue_manager.h"
 
-#include "base/test/test_simple_task_runner.h"
 #include "base/threading/thread.h"
+#include "cc/test/ordered_simple_task_runner.h"
 #include "cc/test/test_now_source.h"
 #include "content/renderer/scheduler/nestable_task_runner_for_test.h"
 #include "content/renderer/scheduler/renderer_scheduler_message_loop_delegate.h"
@@ -28,6 +28,11 @@ class SelectorForTest : public TaskQueueSelector {
   }
 
   bool SelectWorkQueueToService(size_t* out_queue_index) override {
+    // If there's only one queue then queues_to_service_ is redundant.

[Sami, 2015/03/18 11:13:21]

I'm not sure I agree: the selector can always opt not to run anything even with
just one queue and we should make it possible to test that.

[alex clarke (OOO till 29th), 2015/03/18 12:15:10]

As discussed offline I split the SelectorForTest into two classes.

+    if (work_queues_.size() == 1) {
+      *out_queue_index = 0;
+      return true;
+    }
     if (queues_to_service_.empty())
       return false;
     *out_queue_index = queues_to_service_.front();
@@ -36,6 +41,7 @@ class SelectorForTest : public TaskQueueSelector {
   }
 
   void AppendQueueToService(size_t queue_index) {
+    DCHECK(work_queues_.size() > 1);
     queues_to_service_.push_back(queue_index);
   }
 
@@ -56,11 +62,15 @@ class SelectorForTest : public TaskQueueSelector {
 class TaskQueueManagerTest : public testing::Test {
  protected:
   void Initialize(size_t num_queues) {
-    test_task_runner_ = make_scoped_refptr(new base::TestSimpleTaskRunner());
+    now_src_ = cc::TestNowSource::Create(1000);
+    test_task_runner_ =
+        make_scoped_refptr(new cc::OrderedSimpleTaskRunner(now_src_, false));
     selector_ = make_scoped_ptr(new SelectorForTest);
     manager_ = make_scoped_ptr(new TaskQueueManager(
         num_queues, NestableTaskRunnerForTest::Create(test_task_runner_.get()),
         selector_.get()));
+    manager_->SetTimeSourceForTesting(now_src_);
+
     EXPECT_EQ(num_queues, selector_->work_queues().size());
   }
 
@@ -74,7 +84,8 @@ class TaskQueueManagerTest : public testing::Test {
     EXPECT_EQ(num_queues, selector_->work_queues().size());
   }
 
-  scoped_refptr<base::TestSimpleTaskRunner> test_task_runner_;
+  scoped_refptr<cc::TestNowSource> now_src_;
+  scoped_refptr<cc::OrderedSimpleTaskRunner> test_task_runner_;
   scoped_ptr<SelectorForTest> selector_;
   scoped_ptr<TaskQueueManager> manager_;
   scoped_ptr<base::MessageLoop> message_loop_;
@@ -109,10 +120,6 @@ TEST_F(TaskQueueManagerTest, SingleQueuePosting) {
   runner->PostTask(FROM_HERE, base::Bind(&TestTask, 2, &run_order));
   runner->PostTask(FROM_HERE, base::Bind(&TestTask, 3, &run_order));
 
-  selector_->AppendQueueToService(0);
-  selector_->AppendQueueToService(0);
-  selector_->AppendQueueToService(0);
-
   test_task_runner_->RunUntilIdle();
   EXPECT_THAT(run_order, ElementsAre(1, 2, 3));
 }
@@ -144,6 +151,39 @@ TEST_F(TaskQueueManagerTest, MultiQueuePosting) {
   EXPECT_THAT(run_order, ElementsAre(1, 3, 5, 2, 4, 6));
 }
 
+void NopTask() {
+}
+
+TEST_F(TaskQueueManagerTest, NowNotCalledWhenThereAreNoDelayedTasks) {

[Sami, 2015/03/18 11:13:21]

Thanks, this is a great thing to test!

+  Initialize(3u);
+
+  scoped_refptr<cc::TestNowSource> now_src = cc::TestNowSource::Create(1000);
+  manager_->SetTimeSourceForTesting(now_src);
+
+  scoped_refptr<base::SingleThreadTaskRunner> runners[3] = {
+      manager_->TaskRunnerForQueue(0),
+      manager_->TaskRunnerForQueue(1),
+      manager_->TaskRunnerForQueue(2)};
+
+  selector_->AppendQueueToService(0);
+  selector_->AppendQueueToService(1);
+  selector_->AppendQueueToService(2);
+  selector_->AppendQueueToService(0);
+  selector_->AppendQueueToService(1);
+  selector_->AppendQueueToService(2);
+
+  runners[0]->PostTask(FROM_HERE, base::Bind(&NopTask));
+  runners[0]->PostTask(FROM_HERE, base::Bind(&NopTask));
+  runners[1]->PostTask(FROM_HERE, base::Bind(&NopTask));
+  runners[1]->PostTask(FROM_HERE, base::Bind(&NopTask));
+  runners[2]->PostTask(FROM_HERE, base::Bind(&NopTask));
+  runners[2]->PostTask(FROM_HERE, base::Bind(&NopTask));
+
+  test_task_runner_->RunUntilIdle();
+
+  EXPECT_EQ(0, now_src->NumNowCalls());
+}
+
 TEST_F(TaskQueueManagerTest, NonNestableTaskPosting) {
   InitializeWithRealMessageLoop(1u);
 
@@ -151,8 +191,6 @@ TEST_F(TaskQueueManagerTest, NonNestableTaskPosting) {
   scoped_refptr<base::SingleThreadTaskRunner> runner =
       manager_->TaskRunnerForQueue(0);
 
-  selector_->AppendQueueToService(0);
-
   runner->PostNonNestableTask(FROM_HERE, base::Bind(&TestTask, 1, &run_order));
 
   message_loop_->RunUntilIdle();
@@ -166,12 +204,6 @@ TEST_F(TaskQueueManagerTest, NonNestableTaskExecutesInExpectedOrder) {
   scoped_refptr<base::SingleThreadTaskRunner> runner =
       manager_->TaskRunnerForQueue(0);
 
-  selector_->AppendQueueToService(0);
-  selector_->AppendQueueToService(0);
-  selector_->AppendQueueToService(0);
-  selector_->AppendQueueToService(0);
-  selector_->AppendQueueToService(0);
-
   runner->PostTask(FROM_HERE, base::Bind(&TestTask, 1, &run_order));
   runner->PostTask(FROM_HERE, base::Bind(&TestTask, 2, &run_order));
   runner->PostTask(FROM_HERE, base::Bind(&TestTask, 3, &run_order));
@@ -189,13 +221,6 @@ TEST_F(TaskQueueManagerTest, NonNestableTaskDoesntExecuteInNestedLoop) {
   scoped_refptr<base::SingleThreadTaskRunner> runner =
       manager_->TaskRunnerForQueue(0);
 
-  selector_->AppendQueueToService(0);
-  selector_->AppendQueueToService(0);
-  selector_->AppendQueueToService(0);
-  selector_->AppendQueueToService(0);
-  selector_->AppendQueueToService(0);
-  selector_->AppendQueueToService(0);
-
   runner->PostTask(FROM_HERE, base::Bind(&TestTask, 1, &run_order));
   runner->PostTask(FROM_HERE, base::Bind(&TestTask, 2, &run_order));
 
@@ -228,7 +253,6 @@ TEST_F(TaskQueueManagerTest, QueuePolling) {
   runner->PostTask(FROM_HERE, base::Bind(&TestTask, 1, &run_order));
   EXPECT_FALSE(manager_->IsQueueEmpty(0));
 
-  selector_->AppendQueueToService(0);
   test_task_runner_->RunUntilIdle();
   EXPECT_TRUE(manager_->IsQueueEmpty(0));
 }
@@ -240,49 +264,133 @@ TEST_F(TaskQueueManagerTest, DelayedTaskPosting) {
   scoped_refptr<base::SingleThreadTaskRunner> runner =
       manager_->TaskRunnerForQueue(0);
 
-  selector_->AppendQueueToService(0);
-
   base::TimeDelta delay(base::TimeDelta::FromMilliseconds(10));
   runner->PostDelayedTask(
       FROM_HERE, base::Bind(&TestTask, 1, &run_order), delay);
-  EXPECT_EQ(delay, test_task_runner_->NextPendingTaskDelay());
+  EXPECT_EQ(delay, test_task_runner_->DelayToNextTaskTime());
   EXPECT_TRUE(manager_->IsQueueEmpty(0));
   EXPECT_TRUE(run_order.empty());
 
-  // The task is inserted to the incoming queue only after the delay.
-  test_task_runner_->RunPendingTasks();
-  EXPECT_FALSE(manager_->IsQueueEmpty(0));
+  // The task doesn't run before the delay has completed.
+  test_task_runner_->RunForPeriod(base::TimeDelta::FromMilliseconds(9));
   EXPECT_TRUE(run_order.empty());
 
-  // After the delay the task runs normally.
-  selector_->AppendQueueToService(0);
-  test_task_runner_->RunUntilIdle();
+  // After the delay has completed, the task runs normally.
+  test_task_runner_->RunForPeriod(base::TimeDelta::FromMilliseconds(1));
   EXPECT_THAT(run_order, ElementsAre(1));
 }
 
-TEST_F(TaskQueueManagerTest, DelayedTaskDoesNotStayDelayed) {
+TEST_F(TaskQueueManagerTest, DelayedTaskPosting_MultipleTasks_DecendingOrder) {
   Initialize(1u);
 
   std::vector<int> run_order;
   scoped_refptr<base::SingleThreadTaskRunner> runner =
       manager_->TaskRunnerForQueue(0);
 
-  selector_->AppendQueueToService(0);
+  runner->PostDelayedTask(FROM_HERE, base::Bind(&TestTask, 1, &run_order),
+                          base::TimeDelta::FromMilliseconds(10));
+
+  runner->PostDelayedTask(FROM_HERE, base::Bind(&TestTask, 2, &run_order),
+                          base::TimeDelta::FromMilliseconds(8));
+
+  runner->PostDelayedTask(FROM_HERE, base::Bind(&TestTask, 3, &run_order),
+                          base::TimeDelta::FromMilliseconds(5));
+
+  EXPECT_EQ(base::TimeDelta::FromMilliseconds(5),
+            test_task_runner_->DelayToNextTaskTime());
+
+  test_task_runner_->RunForPeriod(base::TimeDelta::FromMilliseconds(5));
+  EXPECT_THAT(run_order, ElementsAre(3));
+  EXPECT_EQ(base::TimeDelta::FromMilliseconds(3),
+            test_task_runner_->DelayToNextTaskTime());
+
+  test_task_runner_->RunForPeriod(base::TimeDelta::FromMilliseconds(3));
+  EXPECT_THAT(run_order, ElementsAre(3, 2));
+  EXPECT_EQ(base::TimeDelta::FromMilliseconds(2),
+            test_task_runner_->DelayToNextTaskTime());
+
+  test_task_runner_->RunForPeriod(base::TimeDelta::FromMilliseconds(2));
+  EXPECT_THAT(run_order, ElementsAre(3, 2, 1));
+}
+
+TEST_F(TaskQueueManagerTest, DelayedTaskPosting_MultipleTasks_AscendingOrder) {
+  Initialize(1u);
+
+  std::vector<int> run_order;
+  scoped_refptr<base::SingleThreadTaskRunner> runner =
+      manager_->TaskRunnerForQueue(0);
+
+  runner->PostDelayedTask(FROM_HERE, base::Bind(&TestTask, 1, &run_order),
+                          base::TimeDelta::FromMilliseconds(1));
+
+  runner->PostDelayedTask(FROM_HERE, base::Bind(&TestTask, 2, &run_order),
+                          base::TimeDelta::FromMilliseconds(5));
+
+  runner->PostDelayedTask(FROM_HERE, base::Bind(&TestTask, 3, &run_order),
+                          base::TimeDelta::FromMilliseconds(10));
+
+  EXPECT_EQ(base::TimeDelta::FromMilliseconds(1),
+            test_task_runner_->DelayToNextTaskTime());
+
+  test_task_runner_->RunForPeriod(base::TimeDelta::FromMilliseconds(1));
+  EXPECT_THAT(run_order, ElementsAre(1));
+  EXPECT_EQ(base::TimeDelta::FromMilliseconds(4),
+            test_task_runner_->DelayToNextTaskTime());
+
+  test_task_runner_->RunForPeriod(base::TimeDelta::FromMilliseconds(4));
+  EXPECT_THAT(run_order, ElementsAre(1, 2));
+  EXPECT_EQ(base::TimeDelta::FromMilliseconds(5),
+            test_task_runner_->DelayToNextTaskTime());
+
+  test_task_runner_->RunForPeriod(base::TimeDelta::FromMilliseconds(5));
+  EXPECT_THAT(run_order, ElementsAre(1, 2, 3));
+}
+
+TEST_F(TaskQueueManagerTest, PostDelayedTask_SharesUnderlyingDelayedTasks) {
+  Initialize(1u);
+
+  std::vector<int> run_order;
+  scoped_refptr<base::SingleThreadTaskRunner> runner =
+      manager_->TaskRunnerForQueue(0);
 
   base::TimeDelta delay(base::TimeDelta::FromMilliseconds(10));
   runner->PostDelayedTask(FROM_HERE, base::Bind(&TestTask, 1, &run_order),
                           delay);
-  test_task_runner_->RunPendingTasks();
+  runner->PostDelayedTask(FROM_HERE, base::Bind(&TestTask, 2, &run_order),
+                          delay);
+  runner->PostDelayedTask(FROM_HERE, base::Bind(&TestTask, 3, &run_order),
+                          delay);
 
-  // Reload the work queue so we see the next pending task. It should no longer
-  // be marked as delayed.
-  manager_->PumpQueue(0);
-  EXPECT_TRUE(selector_->work_queues()[0]->front().delayed_run_time.is_null());
+  EXPECT_EQ(1u, test_task_runner_->NumPendingTasks());
+}
 
-  // Let the task run normally.
-  selector_->AppendQueueToService(0);
-  test_task_runner_->RunUntilIdle();
-  EXPECT_THAT(run_order, ElementsAre(1));
+class TestObject {
+ public:
+  ~TestObject() { destructor_count_++; }
+
+  void Run() { FAIL() << "TestObject::Run should not be called"; }
+
+  static int destructor_count_;
+};
+
+int TestObject::destructor_count_ = 0;
+
+TEST_F(TaskQueueManagerTest, PendingDelayedTasksRemovedOnShutdown) {
+  Initialize(1u);
+
+  TestObject::destructor_count_ = 0;
+
+  scoped_refptr<base::SingleThreadTaskRunner> runner =
+      manager_->TaskRunnerForQueue(0);
+
+  base::TimeDelta delay(base::TimeDelta::FromMilliseconds(10));
+  runner->PostDelayedTask(
+      FROM_HERE, base::Bind(&TestObject::Run, base::Owned(new TestObject())),
+      delay);
+
+  manager_.reset();
+
+  EXPECT_EQ(1, TestObject::destructor_count_);
 }
 
 TEST_F(TaskQueueManagerTest, ManualPumping) {
@@ -296,15 +404,14 @@ TEST_F(TaskQueueManagerTest, ManualPumping) {
   // Posting a task when pumping is disabled doesn't result in work getting
   // posted.
   runner->PostTask(FROM_HERE, base::Bind(&TestTask, 1, &run_order));
-  EXPECT_FALSE(test_task_runner_->HasPendingTask());
+  EXPECT_FALSE(test_task_runner_->HasPendingTasks());
 
   // However polling still works.
   EXPECT_FALSE(manager_->IsQueueEmpty(0));
 
   // After pumping the task runs normally.
   manager_->PumpQueue(0);
-  EXPECT_TRUE(test_task_runner_->HasPendingTask());
-  selector_->AppendQueueToService(0);
+  EXPECT_TRUE(test_task_runner_->HasPendingTasks());
   test_task_runner_->RunUntilIdle();
   EXPECT_THAT(run_order, ElementsAre(1));
 }
@@ -320,18 +427,18 @@ TEST_F(TaskQueueManagerTest, ManualPumpingToggle) {
   // Posting a task when pumping is disabled doesn't result in work getting
   // posted.
   runner->PostTask(FROM_HERE, base::Bind(&TestTask, 1, &run_order));
-  EXPECT_FALSE(test_task_runner_->HasPendingTask());
+  EXPECT_FALSE(test_task_runner_->HasPendingTasks());
 
   // When pumping is enabled the task runs normally.
   manager_->SetPumpPolicy(0, TaskQueueManager::PumpPolicy::AUTO);
-  EXPECT_TRUE(test_task_runner_->HasPendingTask());
-  selector_->AppendQueueToService(0);
+  EXPECT_TRUE(test_task_runner_->HasPendingTasks());
   test_task_runner_->RunUntilIdle();
   EXPECT_THAT(run_order, ElementsAre(1));
 }
 
 TEST_F(TaskQueueManagerTest, DenyRunning) {
-  Initialize(1u);
+  Initialize(
+      2u);  // Because AppendQueueToService is ignored if there's 1 queue.
 
   std::vector<int> run_order;
   scoped_refptr<base::SingleThreadTaskRunner> runner =
@@ -363,15 +470,64 @@ TEST_F(TaskQueueManagerTest, ManualPumpingWithDelayedTask) {
   base::TimeDelta delay(base::TimeDelta::FromMilliseconds(10));
   runner->PostDelayedTask(
       FROM_HERE, base::Bind(&TestTask, 1, &run_order), delay);
+
+  // After pumping but before the delay period has expired, task does not run.
+  manager_->PumpQueue(0);
+  test_task_runner_->RunForPeriod(base::TimeDelta::FromMilliseconds(5));
+  EXPECT_TRUE(run_order.empty());
+
+  // Once the delay has expired, pumping causes the task to run.
+  now_src_->AdvanceNow(base::TimeDelta::FromMilliseconds(5));
+  manager_->PumpQueue(0);
+  EXPECT_TRUE(test_task_runner_->HasPendingTasks());
+  test_task_runner_->RunPendingTasks();
+  EXPECT_THAT(run_order, ElementsAre(1));
+}
+
+TEST_F(TaskQueueManagerTest, ManualPumpingWithMultipleDelayedTasks) {
+  Initialize(1u);
+  manager_->SetPumpPolicy(0, TaskQueueManager::PumpPolicy::MANUAL);
+
+  std::vector<int> run_order;
+  scoped_refptr<base::SingleThreadTaskRunner> runner =
+      manager_->TaskRunnerForQueue(0);
+
+  // Posting a delayed task when pumping will apply the delay, but won't cause
+  // work to executed afterwards.
+  base::TimeDelta delay1(base::TimeDelta::FromMilliseconds(1));
+  base::TimeDelta delay2(base::TimeDelta::FromMilliseconds(10));
+  base::TimeDelta delay3(base::TimeDelta::FromMilliseconds(20));
+  runner->PostDelayedTask(FROM_HERE, base::Bind(&TestTask, 1, &run_order),
+                          delay1);
+  runner->PostDelayedTask(FROM_HERE, base::Bind(&TestTask, 2, &run_order),
+                          delay2);
+  runner->PostDelayedTask(FROM_HERE, base::Bind(&TestTask, 3, &run_order),
+                          delay3);
+
+  now_src_->AdvanceNow(base::TimeDelta::FromMilliseconds(15));
   test_task_runner_->RunUntilIdle();
   EXPECT_TRUE(run_order.empty());
 
-  // After pumping the task runs normally.
+  // Once the delay has expired, pumping causes the task to run.
   manager_->PumpQueue(0);
-  EXPECT_TRUE(test_task_runner_->HasPendingTask());
-  selector_->AppendQueueToService(0);
   test_task_runner_->RunUntilIdle();
-  EXPECT_THAT(run_order, ElementsAre(1));
+  EXPECT_THAT(run_order, ElementsAre(1, 2));
+}
+
+TEST_F(TaskQueueManagerTest, DelayedTasksDontAutoRunWithManualPumping) {
+  Initialize(1u);
+  manager_->SetPumpPolicy(0, TaskQueueManager::PumpPolicy::MANUAL);
+
+  std::vector<int> run_order;
+  scoped_refptr<base::SingleThreadTaskRunner> runner =
+      manager_->TaskRunnerForQueue(0);
+
+  base::TimeDelta delay(base::TimeDelta::FromMilliseconds(10));
+  runner->PostDelayedTask(FROM_HERE, base::Bind(&TestTask, 1, &run_order),
+                          delay);
+
+  test_task_runner_->RunForPeriod(base::TimeDelta::FromMilliseconds(10));
+  EXPECT_TRUE(run_order.empty());
 }
 
 TEST_F(TaskQueueManagerTest, ManualPumpingWithNonEmptyWorkQueue) {
@@ -411,10 +567,6 @@ TEST_F(TaskQueueManagerTest, ReentrantPosting) {
 
   runner->PostTask(FROM_HERE, Bind(&ReentrantTestTask, runner, 3, &run_order));
 
-  selector_->AppendQueueToService(0);
-  selector_->AppendQueueToService(0);
-  selector_->AppendQueueToService(0);
-
   test_task_runner_->RunUntilIdle();
   EXPECT_THAT(run_order, ElementsAre(3, 2, 1));
 }
@@ -453,7 +605,6 @@ TEST_F(TaskQueueManagerTest, PostFromThread) {
       FROM_HERE, base::Bind(&PostTaskToRunner, runner, &run_order));
   thread.Stop();
 
-  selector_->AppendQueueToService(0);
   message_loop_->RunUntilIdle();
   EXPECT_THAT(run_order, ElementsAre(1));
 }
@@ -475,25 +626,16 @@ TEST_F(TaskQueueManagerTest, DoWorkCantPostItselfMultipleTimes) {
   runner->PostTask(FROM_HERE,
                    base::Bind(&RePostingTestTask, runner, &run_count));
 
-  selector_->AppendQueueToService(0);
-  selector_->AppendQueueToService(0);
-  selector_->AppendQueueToService(0);
-
   test_task_runner_->RunPendingTasks();
   // NOTE without the executing_task_ check in MaybePostDoWorkOnMainRunner there
   // will be two tasks here.
-  EXPECT_EQ(1u, test_task_runner_->GetPendingTasks().size());
+  EXPECT_EQ(1u, test_task_runner_->NumPendingTasks());
   EXPECT_EQ(1, run_count);
 }
 
 TEST_F(TaskQueueManagerTest, PostFromNestedRunloop) {
   InitializeWithRealMessageLoop(1u);
 
-  selector_->AppendQueueToService(0);
-  selector_->AppendQueueToService(0);
-  selector_->AppendQueueToService(0);
-  selector_->AppendQueueToService(0);
-
   std::vector<int> run_order;
   scoped_refptr<base::SingleThreadTaskRunner> runner =
       manager_->TaskRunnerForQueue(0);
@@ -522,11 +664,6 @@ TEST_F(TaskQueueManagerTest, WorkBatching) {
   scoped_refptr<base::SingleThreadTaskRunner> runner =
       manager_->TaskRunnerForQueue(0);
 
-  selector_->AppendQueueToService(0);
-  selector_->AppendQueueToService(0);
-  selector_->AppendQueueToService(0);
-  selector_->AppendQueueToService(0);
-
   runner->PostTask(FROM_HERE, base::Bind(&TestTask, 1, &run_order));
   runner->PostTask(FROM_HERE, base::Bind(&TestTask, 2, &run_order));
   runner->PostTask(FROM_HERE, base::Bind(&TestTask, 3, &run_order));
@@ -534,61 +671,16 @@ TEST_F(TaskQueueManagerTest, WorkBatching) {
 
   // Running one task in the host message loop should cause two posted tasks to
   // get executed.
-  EXPECT_EQ(test_task_runner_->GetPendingTasks().size(), 1u);
+  EXPECT_EQ(test_task_runner_->NumPendingTasks(), 1u);
   test_task_runner_->RunPendingTasks();
   EXPECT_THAT(run_order, ElementsAre(1, 2));
 
   // The second task runs the remaining two posted tasks.
-  EXPECT_EQ(test_task_runner_->GetPendingTasks().size(), 1u);
+  EXPECT_EQ(test_task_runner_->NumPendingTasks(), 1u);
   test_task_runner_->RunPendingTasks();
   EXPECT_THAT(run_order, ElementsAre(1, 2, 3, 4));
 }
 
-void AdvanceNowTestTask(int value,
-                        std::vector<int>* out_result,
-                        scoped_refptr<cc::TestNowSource> time_source,
-                        base::TimeDelta delta) {
-  TestTask(value, out_result);
-  time_source->AdvanceNow(delta);
-}
-
-TEST_F(TaskQueueManagerTest, InterruptWorkBatchForDelayedTask) {
-  scoped_refptr<cc::TestNowSource> clock(cc::TestNowSource::Create());
-  Initialize(1u);
-
-  manager_->SetWorkBatchSize(2);
-  manager_->SetTimeSourceForTesting(clock);
-
-  std::vector<int> run_order;
-  scoped_refptr<base::SingleThreadTaskRunner> runner =
-      manager_->TaskRunnerForQueue(0);
-
-  selector_->AppendQueueToService(0);
-  selector_->AppendQueueToService(0);
-  selector_->AppendQueueToService(0);
-
-  base::TimeDelta delta(base::TimeDelta::FromMilliseconds(10));
-  runner->PostTask(
-      FROM_HERE, base::Bind(&AdvanceNowTestTask, 2, &run_order, clock, delta));
-  runner->PostTask(
-      FROM_HERE, base::Bind(&AdvanceNowTestTask, 3, &run_order, clock, delta));
-
-  base::TimeDelta delay(base::TimeDelta::FromMilliseconds(5));
-  runner->PostDelayedTask(FROM_HERE, base::Bind(&TestTask, 1, &run_order),
-                          delay);
-
-  // At this point we have two posted tasks: one for DoWork and one of the
-  // delayed task. Only the first non-delayed task should get executed because
-  // the work batch is interrupted by the pending delayed task.
-  EXPECT_EQ(test_task_runner_->GetPendingTasks().size(), 2u);
-  test_task_runner_->RunPendingTasks();
-  EXPECT_THAT(run_order, ElementsAre(2));
-
-  // Running all remaining tasks should execute both pending tasks.
-  test_task_runner_->RunUntilIdle();
-  EXPECT_THAT(run_order, ElementsAre(2, 3, 1));
-}
-
 TEST_F(TaskQueueManagerTest, AutoPumpAfterWakeup) {
   Initialize(2u);
   manager_->SetPumpPolicy(0, TaskQueueManager::PumpPolicy::AFTER_WAKEUP);
@@ -725,9 +817,6 @@ TEST_F(TaskQueueManagerTest, AutoPumpAfterWakeupFromMultipleTasks) {
   EXPECT_THAT(run_order, ElementsAre(3, 1, 2));
 }
 
-void NullTestTask() {
-}
-
 TEST_F(TaskQueueManagerTest, AutoPumpAfterWakeupBecomesQuiescent) {
   Initialize(2u);
   manager_->SetPumpPolicy(0, TaskQueueManager::PumpPolicy::AFTER_WAKEUP);
@@ -751,7 +840,7 @@ TEST_F(TaskQueueManagerTest, AutoPumpAfterWakeupBecomesQuiescent) {
                        base::Bind(&RePostingTestTask, runners[0], &run_count));
   runners[0]->PostTask(FROM_HERE,
                        base::Bind(&RePostingTestTask, runners[0], &run_count));
-  runners[1]->PostTask(FROM_HERE, base::Bind(&NullTestTask));
+  runners[1]->PostTask(FROM_HERE, base::Bind(&NopTask));
   test_task_runner_->RunUntilIdle();
   // The reposting tasks posted to the after wakeup queue shouldn't have woken
   // each other up.
@@ -778,9 +867,6 @@ TEST_F(TaskQueueManagerTest, TaskObserverAdding) {
   runner->PostTask(FROM_HERE, base::Bind(&TestTask, 1, &run_order));
   runner->PostTask(FROM_HERE, base::Bind(&TestTask, 2, &run_order));
 
-  selector_->AppendQueueToService(0);
-  selector_->AppendQueueToService(0);
-
   // Two pairs of callbacks for the tasks above plus another one for the
   // DoWork() posted by the task queue manager.
   EXPECT_CALL(observer, WillProcessTask(_)).Times(3);
@@ -804,7 +890,6 @@ TEST_F(TaskQueueManagerTest, TaskObserverRemoving) {
   EXPECT_CALL(observer, WillProcessTask(_)).Times(0);
   EXPECT_CALL(observer, DidProcessTask(_)).Times(0);
 
-  selector_->AppendQueueToService(0);
   message_loop_->RunUntilIdle();
 }
 
@@ -824,8 +909,6 @@ TEST_F(TaskQueueManagerTest, TaskObserverRemovingInsideTask) {
   runner->PostTask(FROM_HERE,
                    base::Bind(&RemoveObserverTask, manager_.get(), &observer));
 
-  selector_->AppendQueueToService(0);
-
   EXPECT_CALL(observer, WillProcessTask(_)).Times(1);
   EXPECT_CALL(observer, DidProcessTask(_)).Times(0);
   message_loop_->RunUntilIdle();