Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(544)

Unified Diff: handler/mac/crash_report_upload_thread.cc

Issue 1008623002: handler/mac: Increase the upload timeout from the default 15s to 60s. (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: handler/mac/crash_report_upload_thread.cc
diff --git a/handler/mac/crash_report_upload_thread.cc b/handler/mac/crash_report_upload_thread.cc
index 0e77ee730a0d585338830b7ba80a33e7a52b905f..a4e4607d0c57bf4d6c96a1ad85e9bde5b0b02e93 100644
--- a/handler/mac/crash_report_upload_thread.cc
+++ b/handler/mac/crash_report_upload_thread.cc
@@ -343,13 +343,14 @@ CrashReportUploadThread::UploadResult CrashReportUploadThread::UploadReport(
report->file_path,
"application/octet-stream");
- // TODO(mark): There should be a timeout option for upload.
scoped_ptr<HTTPTransport> http_transport(HTTPTransport::Create());
http_transport->SetURL(url_);
HTTPHeaders::value_type content_type =
http_multipart_builder.GetContentType();
http_transport->SetHeader(content_type.first, content_type.second);
http_transport->SetBodyStream(http_multipart_builder.GetBodyStream().Pass());
+ // TODO(mark): The timeout should be configurable by the client.
+ http_transport->SetTimeout(60.0); // 1 minute.
if (!http_transport->ExecuteSynchronously(response_body)) {
return UploadResult::kRetry;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698