content/browser/devtools/shared_worker_devtools_manager.cc - Issue 1008613002: favor DCHECK_CURRENTLY_ON for better logs in content/browser/[a-d]*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/devtools/shared_worker_devtools_manager.cc

Issue 1008613002: favor DCHECK_CURRENTLY_ON for better logs in content/browser/[a-d]* (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/devtools/service_worker_devtools_manager.cc ('k') | content/browser/devtools/worker_devtools_agent_host.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/devtools/shared_worker_devtools_manager.cc

diff --git a/content/browser/devtools/shared_worker_devtools_manager.cc b/content/browser/devtools/shared_worker_devtools_manager.cc

index 9b83f51c2de3e8d6b42b2d5582eae02f98a42547..3fb2cf111c308d938fcdba8f03eed668babec7db 100644

--- a/content/browser/devtools/shared_worker_devtools_manager.cc

+++ b/content/browser/devtools/shared_worker_devtools_manager.cc

@@ -13,7 +13,7 @@ namespace content {

// static

SharedWorkerDevToolsManager* SharedWorkerDevToolsManager::GetInstance() {

- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));

+ DCHECK_CURRENTLY_ON(BrowserThread::UI);

return Singleton<SharedWorkerDevToolsManager>::get();

}

@@ -38,7 +38,7 @@ bool SharedWorkerDevToolsManager::WorkerCreated(

int worker_process_id,

int worker_route_id,

const SharedWorkerInstance& instance) {

- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));

+ DCHECK_CURRENTLY_ON(BrowserThread::UI);

const WorkerId id(worker_process_id, worker_route_id);

AgentHostMap::iterator it =

FindExistingWorkerAgentHost(instance);

@@ -60,7 +60,7 @@ bool SharedWorkerDevToolsManager::WorkerCreated(

void SharedWorkerDevToolsManager::WorkerReadyForInspection(

int worker_process_id,

int worker_route_id) {

- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));

+ DCHECK_CURRENTLY_ON(BrowserThread::UI);

const WorkerId id(worker_process_id, worker_route_id);

AgentHostMap::iterator it = workers_.find(id);

DCHECK(it != workers_.end());

@@ -70,7 +70,7 @@ void SharedWorkerDevToolsManager::WorkerReadyForInspection(

void SharedWorkerDevToolsManager::WorkerDestroyed(

int worker_process_id,

int worker_route_id) {

- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));

+ DCHECK_CURRENTLY_ON(BrowserThread::UI);

const WorkerId id(worker_process_id, worker_route_id);

AgentHostMap::iterator it = workers_.find(id);

DCHECK(it != workers_.end());

@@ -80,7 +80,7 @@ void SharedWorkerDevToolsManager::WorkerDestroyed(

}

void SharedWorkerDevToolsManager::RemoveInspectedWorkerData(WorkerId id) {

- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));

+ DCHECK_CURRENTLY_ON(BrowserThread::UI);

workers_.erase(id);

}

SharedWorkerDevToolsManager::SharedWorkerDevToolsManager() {