Move MediaController.java upstream to Chromium repository.

Move MediaController.java upstream to Chromium repository.

MediaController.java is used by the android cast code which upstreamed from the private Chrome for Android repository.
It derives from open source Android source code,
specifically from one of the Android supportv4 samples, and has been
in the downstream repository for some time.

See the README.chromium file for more details.

BUG=315088
Committed: https://crrev.com/065f7af598e8000c967d878a71f4c0e556fc1a03
Cr-Commit-Position: refs/heads/master@{#322461}

[aberent, 2015-03-13 09:26:58]

aberent@chromium.org changed reviewers:
+ cpu@chromium.org

[aberent, 2015-03-13 09:26:59]

New CL as requested, separating this from
https://codereview.chromium.org/928643003/. Added security@chromium.org and
open-source-third-party-reviews@google.com to the cc list so that they can
confirm that they have no concerns about this (as required by the Chromium
process for third party code).

cpu@ - please review.

[cpu_(ooo_6.6-7.5), 2015-03-16 17:43:19]

the last two files ... we must go deeper.

[aberent, 2015-03-17 09:46:25]

On 2015/03/16 17:43:19, cpu wrote:
> the last two files ... we must go deeper.

Please expand. Do you need more information from me?

[Ryan Sleevi, 2015-03-17 10:12:44]

https://codereview.chromium.org/1008603003/diff/1/third_party/android_media/R...
File third_party/android_media/README.chromium (right):

https://codereview.chromium.org/1008603003/diff/1/third_party/android_media/R...
third_party/android_media/README.chromium:3: Version: unknown
What githash did you check these out at? Include that here.

https://codereview.chromium.org/1008603003/diff/1/third_party/android_media/R...
third_party/android_media/README.chromium:12: MediaController.java is based on a
public supportv4 android sample.
Link to sample? How can we diff this from upstream? Where even is upstream? What
if there are more minor bug fixes?

[aberent, 2015-03-17 20:50:38]

On 2015/03/17 10:12:44, Ryan Sleevi wrote:
>
https://codereview.chromium.org/1008603003/diff/1/third_party/android_media/R...
> File third_party/android_media/README.chromium (right):
> 
>
https://codereview.chromium.org/1008603003/diff/1/third_party/android_media/R...
> third_party/android_media/README.chromium:3: Version: unknown
> What githash did you check these out at? Include that here.
> 
>
https://codereview.chromium.org/1008603003/diff/1/third_party/android_media/R...
> third_party/android_media/README.chromium:12: MediaController.java is based on
a
> public supportv4 android sample.
> Link to sample? How can we diff this from upstream? Where even is upstream?
What
> if there are more minor bug fixes?

Note that I have removed ChromeMediaRouterNotificationDialog.java. It turns out
that, with a few minor changes to the code in
https://codereview.chromium.org/928643003/ we no longer need it.

[aberent, 2015-03-17 20:51:09]

https://codereview.chromium.org/1008603003/diff/1/third_party/android_media/R...
File third_party/android_media/README.chromium (right):

https://codereview.chromium.org/1008603003/diff/1/third_party/android_media/R...
third_party/android_media/README.chromium:3: Version: unknown
On 2015/03/17 10:12:44, Ryan Sleevi wrote:
> What githash did you check these out at? Include that here.

Done.

https://codereview.chromium.org/1008603003/diff/1/third_party/android_media/R...
third_party/android_media/README.chromium:12: MediaController.java is based on a
public supportv4 android sample.
On 2015/03/17 10:12:44, Ryan Sleevi wrote:
> Link to sample? How can we diff this from upstream? Where even is upstream?
What
> if there are more minor bug fixes?

Link to sample added. This is the upstream version, downstream (Clank) version
is
https://cs.corp.google.com/#clank/java/apps/chrome/src/com/google/android/app....
Any future bug fixes will be done here, since the downstream version will be
removed once this and https://codereview.chromium.org/928643003/ land.

[cpu_(ooo_6.6-7.5), 2015-03-18 22:02:30]

third_party/android_media/java/src/org/chromium/third_party/

that is a nonsensical path now, as it reads to me:

chromium/third_party/android_media/java/src/org/chromium/

what is the rationale?

[aberent, 2015-03-19 09:26:06]

On 2015/03/18 22:02:30, cpu wrote:
> third_party/android_media/java/src/org/chromium/third_party/
> 
> that is a nonsensical path now, as it reads to me:
> 
> chromium/third_party/android_media/java/src/org/chromium/
> 
> what is the rationale?

The Java tools (like all Java tools I know of) require the last part of the path
(after the src) to match the package name. The package name is
org.chromium.third_party.android.media, so the source path has to be
.../org/chromium/third_party/android/media/MediaRouteController.java

See third_party/android_data_chart, which has exactly the same structure.

[cpu_(ooo_6.6-7.5), 2015-03-20 19:23:04]

ah, of course. It shows I know nothing of java.

do you have the open source license folks review?

http://www.chromium.org/developers/adding-3rd-party-libraries

[aberent, 2015-03-23 09:40:36]

On 2015/03/20 19:23:04, cpu wrote:
> ah, of course. It shows I know nothing of java.
> 
> do you have the open source license folks review?
> 
> http://www.chromium.org/developers/adding-3rd-party-libraries

Not yet. I have requested it, but will ping them again.

[whywhat, 2015-03-26 19:06:22]

avayvod@chromium.org changed reviewers:
+ avayvod@chromium.org, dannyb@google.com

[whywhat, 2015-03-26 19:06:23]

+Danny

[Daniel Berlin, 2015-03-26 19:14:17]

LGTM for OSTPR

[cpu_(ooo_6.6-7.5), 2015-03-26 20:06:35]

lgtm

[aberent, 2015-03-26 20:10:42]

The CQ bit was checked by aberent@chromium.org

[commit-bot: I haz the power, 2015-03-26 20:11:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1008603003/40001

[commit-bot: I haz the power, 2015-03-26 20:34:41]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-03-26 20:35:41]

Patchset 3 (id:??) landed as
https://crrev.com/065f7af598e8000c967d878a71f4c0e556fc1a03
Cr-Commit-Position: refs/heads/master@{#322461}