Support MIPS DSP application-specific extension (ASE).

Support MIPS DSP application-specific extension (ASE).

Define gypi_skia_gpu and gypi_skia_pdf only if they will be used.

R=alokp@chromium.org,reed@google.com
BUG=none

Committed: https://crrev.com/1bf9e8fe3335cddad0b507851d5c2f89bf461282
Cr-Commit-Position: refs/heads/master@{#320978}

[wtc, 2015-03-12 22:03:20]

https://codereview.chromium.org/1008603002/diff/1/skia/BUILD.gn
File skia/BUILD.gn (right):

https://codereview.chromium.org/1008603002/diff/1/skia/BUILD.gn#newcode596
skia/BUILD.gn:596: }

The new code I added mimics the code for SSE2 and armv7 above.

[alokp, 2015-03-15 05:15:31]

alokp@chromium.org changed reviewers:
+ reed@chromium.org

[alokp, 2015-03-15 05:15:31]

lgtm

+reed for OWNERS approval.

[wtc, 2015-03-17 17:46:10]

The CQ bit was checked by wtc@chromium.org

[commit-bot: I haz the power, 2015-03-17 17:46:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1008603002/1

[wtc, 2015-03-17 17:52:54]

The CQ bit was unchecked by wtc@chromium.org

[wtc, 2015-03-17 18:04:08]

Hi Reed, Alok: please review patch set 2. Thanks.

[wtc, 2015-03-17 18:47:16]

wtc@chromium.org changed reviewers:
+ reed@google.com

[wtc, 2015-03-17 18:50:02]

Hi Reed, Alok: please review patch set 3.

I found that another change was needed. GN does not allow unused variables. If
gypi_skia_gpu or gypi_skia_pdf is ever set to false, the "gn gen" command will
fail with an error like this:

ERROR at //skia/BUILD.gn:66:5: Assignment had no effect.
    exec_script("//build/gypi_to_gn.py",
    ^-----------------------------------
You set the variable "gypi_skia_pdf" here and it was unused before it went
out of scope.

[alokp, 2015-03-17 20:28:58]

lgtm

[reed1, 2015-03-17 20:38:09]

reed@google.com changed reviewers:
+ bungeman@google.com, mtklein@google.com

[reed1, 2015-03-17 20:38:09]

mike, ben, any problems with this GN change?

[mtklein, 2015-03-17 20:42:50]

lgtm

I think we've just been lazy about MIPS in Chromium.  I believe the GYP file
(skia/skia_library_opts.gyp) probably wants the same sort of change... it looks
like we're feeding mipsel and mips64el both none_sources there.

[reed1, 2015-03-17 20:48:46]

lgtm

[wtc, 2015-03-17 21:22:45]

On 2015/03/17 20:42:50, mtklein wrote:
>
> ... I believe the GYP file
> (skia/skia_library_opts.gyp) probably wants the same sort of change... it
looks
> like we're feeding mipsel and mips64el both none_sources there.

Hmm... you are right. I will create a separate CL for the GYP change.

[wtc, 2015-03-17 21:22:50]

The CQ bit was checked by wtc@chromium.org

[commit-bot: I haz the power, 2015-03-17 21:26:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1008603002/40001

[commit-bot: I haz the power, 2015-03-17 21:31:25]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-03-17 21:32:18]

Patchset 3 (id:??) landed as
https://crrev.com/1bf9e8fe3335cddad0b507851d5c2f89bf461282
Cr-Commit-Position: refs/heads/master@{#320978}