Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1008593004: Add Javascript back/forth/go to the NAVIGATION_TYPE_EXISTING_PAGE classification test. (Closed)

Created:
5 years, 9 months ago by Avi (use Gerrit)
Modified:
5 years, 9 months ago
Reviewers:
Charlie Reis
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add Javascript back/forth/go to the NAVIGATION_TYPE_EXISTING_PAGE classification test. BUG=none TEST=more testing Committed: https://crrev.com/c02ec7c414fe2727c636abb457268f3195008b07 Cr-Commit-Position: refs/heads/master@{#320793}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -2 lines) Patch
M content/browser/frame_host/navigation_controller_impl_browsertest.cc View 3 chunks +54 lines, -2 lines 2 comments Download

Messages

Total messages: 8 (2 generated)
Avi (use Gerrit)
How did I forget these?
5 years, 9 months ago (2015-03-14 01:08:23 UTC) #2
Charlie Reis
LGTM https://codereview.chromium.org/1008593004/diff/1/content/browser/frame_host/navigation_controller_impl_browsertest.cc File content/browser/frame_host/navigation_controller_impl_browsertest.cc (right): https://codereview.chromium.org/1008593004/diff/1/content/browser/frame_host/navigation_controller_impl_browsertest.cc#newcode428 content/browser/frame_host/navigation_controller_impl_browsertest.cc:428: EXPECT_EQ(ui::PAGE_TRANSITION_TYPED It's TYPED for renderer-initiated back/forward? I thought ...
5 years, 9 months ago (2015-03-16 19:55:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1008593004/1
5 years, 9 months ago (2015-03-16 20:38:53 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-16 21:07:35 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/c02ec7c414fe2727c636abb457268f3195008b07 Cr-Commit-Position: refs/heads/master@{#320793}
5 years, 9 months ago (2015-03-16 21:08:32 UTC) #7
Avi (use Gerrit)
5 years, 9 months ago (2015-03-16 22:18:36 UTC) #8
Message was sent while issue was closed. 
https://codereview.chromium.org/1008593004/diff/1/content/browser/frame_host/...
File content/browser/frame_host/navigation_controller_impl_browsertest.cc
(right):

https://codereview.chromium.org/1008593004/diff/1/content/browser/frame_host/...
content/browser/frame_host/navigation_controller_impl_browsertest.cc:428:
EXPECT_EQ(ui::PAGE_TRANSITION_TYPED
On 2015/03/16 19:55:51, Charlie Reis wrote:
> It's TYPED for renderer-initiated back/forward?  I thought the default for
> renderer side stuff was LINK.  Huh.  Maybe it's due to the hop over to the
> browser process and back.

I haven't the slightest clue.

Powered by Google App Engine
This is Rietveld 408576698