Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1008543005: Add HTMLViewer command line arg to set user agent (Closed)

Created:
5 years, 9 months ago by DaveMoore
Modified:
5 years, 9 months ago
Reviewers:
jamesr, sky
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add HTMLViewer command line arg to set user agent BUG= Committed: https://crrev.com/a6606dc698030ece6fc3f68e6c670d53c3a90d92 Cr-Commit-Position: refs/heads/master@{#320787}

Patch Set 1 #

Patch Set 2 : formatting #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -4 lines) Patch
M mojo/services/html_viewer/blink_platform_impl.cc View 1 3 chunks +13 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
DaveMoore
formatting
5 years, 9 months ago (2015-03-15 22:35:30 UTC) #1
DaveMoore
5 years, 9 months ago (2015-03-15 22:35:58 UTC) #3
sky
LGTM and +jamesr again
5 years, 9 months ago (2015-03-16 15:42:21 UTC) #5
jamesr
lgtm
5 years, 9 months ago (2015-03-16 19:25:57 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1008543005/20001
5 years, 9 months ago (2015-03-16 20:09:14 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-16 20:38:57 UTC) #9
commit-bot: I haz the power
5 years, 9 months ago (2015-03-16 20:39:23 UTC) #10
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/a6606dc698030ece6fc3f68e6c670d53c3a90d92
Cr-Commit-Position: refs/heads/master@{#320787}

Powered by Google App Engine
This is Rietveld 408576698