Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 1008533004: Migrate to package:html (Closed)

Created:
5 years, 9 months ago by Siggi Cherem (dart-lang)
Modified:
5 years, 9 months ago
CC:
dev-compiler+reviews_dartlang.org
Base URL:
git@github.com:dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M lib/src/codegen/html_codegen.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M lib/src/dependency_graph.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
Siggi Cherem (dart-lang)
the deprecation warnings are errors when we run the analyzer in test.sh :-(
5 years, 9 months ago (2015-03-23 20:15:16 UTC) #2
kevmoo
lgtm
5 years, 9 months ago (2015-03-23 20:19:34 UTC) #3
Siggi Cherem (dart-lang)
5 years, 9 months ago (2015-03-23 20:28:47 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
59765e58ce38b20d918a3f7e707e9270eb0bdd25 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698