Issue 1008483002: Kill CFX_GrowOnlyPool.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1008483002: Kill CFX_GrowOnlyPool. (Closed)

Created:
5 years, 9 months ago by Tom Sepez

Modified:
5 years, 9 months ago

Reviewers:
Lei Zhang

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Kill CFX_GrowOnlyPool. It's unused, and when the time comes, we'll want to put pdfium onto a hardened allocator like partitionAlloc anyways. Along the way, merge adjacent #ifdef __cplusplus blocks, remove a pointless check for __cplusplus inside a .cpp file, and remove a redundant cast. R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/090d683489bfa3f36f1e2624c310ff9ca5836038

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -94 lines)			Patch
	M	core/include/fxcrt/fx_memory.h	View		2 chunks	+2 lines, -44 lines	0 comments	Download
	M	core/src/fxcrt/fx_basic_memmgr.cpp	View		2 chunks	+5 lines, -50 lines	0 comments	Download

Total messages: 4 (1 generated)

Tom Sepez

5 years, 9 months ago (2015-03-12 20:33:36 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
090d683489bfa3f36f1e2624c310ff9ca5836038 (presubmit successful).