Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Side by Side Diff: net/quic/quic_config.cc

Issue 1008473003: QUIC - Initialize QuicConfig's negotiated_value_ to 0. IMO, it is not (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@Create_QUIC_connection_option_88045604
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/quic/quic_config.h" 5 #include "net/quic/quic_config.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 8
9 #include "base/logging.h" 9 #include "base/logging.h"
10 #include "net/quic/crypto/crypto_handshake_message.h" 10 #include "net/quic/crypto/crypto_handshake_message.h"
(...skipping 46 matching lines...) Expand 10 before | Expand all | Expand 10 after
57 QuicConfigPresence presence) 57 QuicConfigPresence presence)
58 : QuicConfigValue(tag, presence), 58 : QuicConfigValue(tag, presence),
59 negotiated_(false) { 59 negotiated_(false) {
60 } 60 }
61 QuicNegotiableValue::~QuicNegotiableValue() {} 61 QuicNegotiableValue::~QuicNegotiableValue() {}
62 62
63 QuicNegotiableUint32::QuicNegotiableUint32(QuicTag tag, 63 QuicNegotiableUint32::QuicNegotiableUint32(QuicTag tag,
64 QuicConfigPresence presence) 64 QuicConfigPresence presence)
65 : QuicNegotiableValue(tag, presence), 65 : QuicNegotiableValue(tag, presence),
66 max_value_(0), 66 max_value_(0),
67 default_value_(0) { 67 default_value_(0),
68 negotiated_value_(0) {
68 } 69 }
69 QuicNegotiableUint32::~QuicNegotiableUint32() {} 70 QuicNegotiableUint32::~QuicNegotiableUint32() {}
70 71
71 void QuicNegotiableUint32::set(uint32 max, uint32 default_value) { 72 void QuicNegotiableUint32::set(uint32 max, uint32 default_value) {
72 DCHECK_LE(default_value, max); 73 DCHECK_LE(default_value, max);
73 max_value_ = max; 74 max_value_ = max;
74 default_value_ = default_value; 75 default_value_ = default_value;
75 } 76 }
76 77
77 uint32 QuicNegotiableUint32::GetUint32() const { 78 uint32 QuicNegotiableUint32::GetUint32() const {
(...skipping 517 matching lines...) Expand 10 before | Expand all | Expand 10 after
595 peer_hello, hello_type, error_details); 596 peer_hello, hello_type, error_details);
596 } 597 }
597 if (error == QUIC_NO_ERROR) { 598 if (error == QUIC_NO_ERROR) {
598 error = connection_options_.ProcessPeerHello( 599 error = connection_options_.ProcessPeerHello(
599 peer_hello, hello_type, error_details); 600 peer_hello, hello_type, error_details);
600 } 601 }
601 return error; 602 return error;
602 } 603 }
603 604
604 } // namespace net 605 } // namespace net
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698