Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Unified Diff: media/blink/websourcebuffer_impl.cc

Issue 1008463002: Fix MSE GC, make it less aggressive, more spec-compliant (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added overflow check to sanity checks and use CHECK instead of DCHECK Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | media/filters/chunk_demuxer.h » ('j') | media/filters/chunk_demuxer.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/blink/websourcebuffer_impl.cc
diff --git a/media/blink/websourcebuffer_impl.cc b/media/blink/websourcebuffer_impl.cc
index e23c24102eb8e4e114d96d0597b23b7b99316216..f4507f36a77e4179dbdab9d267ea42544a04ca5b 100644
--- a/media/blink/websourcebuffer_impl.cc
+++ b/media/blink/websourcebuffer_impl.cc
@@ -83,10 +83,10 @@ blink::WebTimeRanges WebSourceBufferImpl::buffered() {
bool WebSourceBufferImpl::evictCodedFrames(double currentPlaybackTime,
size_t newDataSize) {
- // TODO(servolk): A dummy method to facilitate landing MSE GC changes.
- // Will be replaced with actual implementation in CL
- // https://codereview.chromium.org/1008463002/
- return true;
+ return demuxer_->EvictCodedFrames(
+ id_,
+ base::TimeDelta::FromSecondsD(currentPlaybackTime),
+ newDataSize);
}
void WebSourceBufferImpl::append(
« no previous file with comments | « no previous file | media/filters/chunk_demuxer.h » ('j') | media/filters/chunk_demuxer.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698