media/filters/source_buffer_range.cc - Issue 1008463002: Fix MSE GC, make it less aggressive, more spec-compliant

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/filters/source_buffer_range.cc

Issue 1008463002: Fix MSE GC, make it less aggressive, more spec-compliant (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added new test case: GarbageCollection_SaveDataAtPlaybackPosition Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« media/filters/chunk_demuxer_unittest.cc ('K') | « media/filters/source_buffer_range.h ('k') | media/filters/source_buffer_stream.h » ('j') | media/filters/source_buffer_stream_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: media/filters/source_buffer_range.cc

diff --git a/media/filters/source_buffer_range.cc b/media/filters/source_buffer_range.cc

index 4fad27dbceff01824060ffe30e2fb0b4f0ec14aa..8245a06a0328b5a68f187616f5ad4bb463ec9d25 100644

--- a/media/filters/source_buffer_range.cc

+++ b/media/filters/source_buffer_range.cc

@@ -341,6 +341,16 @@ int SourceBufferRange::GetRemovalGOP(

return bytes_removed;

}

+bool SourceBufferRange::FirstGOPEarlierThanMediaTime(

+ DecodeTimestamp media_time) const {

+ if (keyframe_map_.size() == 1u)

+ return (GetEndTimestamp() < media_time);

+ KeyframeMap::const_iterator second_gop = keyframe_map_.begin();

+ ++second_gop;

+ return second_gop->first <= media_time;

bool SourceBufferRange::FirstGOPContainsNextBufferPosition() const {

if (!HasNextBufferPosition())

return false;