Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(602)

Unified Diff: ash/wm/virtual_keyboard_container_layout_manager.cc

Issue 1008453002: Allow javascript change the virtual keyboard window size and position freely in FLOATING mode (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: nit: fix a compile error Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/wm/virtual_keyboard_container_layout_manager.cc
diff --git a/ash/wm/virtual_keyboard_container_layout_manager.cc b/ash/wm/virtual_keyboard_container_layout_manager.cc
index aae3ec8fbf86e689877058a1b5848fbfd6ef2e52..0d74f48bb3ac0e1350b82f2525f246244d556a5a 100644
--- a/ash/wm/virtual_keyboard_container_layout_manager.cc
+++ b/ash/wm/virtual_keyboard_container_layout_manager.cc
@@ -31,14 +31,8 @@ void VirtualKeyboardContainerLayoutManager::OnWindowResized() {
if (!keyboard_controller)
return;
- // The layout manager for the root window propagates a resize to its
- // immediate children and grandchildren, but stops there. The keyboard
- // container is three levels deep, and therefore needs to be explicitly
- // updated when its parent is resized.
- aura::Window* keyboard_container =
- keyboard_controller->GetContainerWindow();
- if (keyboard_container)
- keyboard_container->SetBounds(parent_container_->bounds());
+ if (keyboard_controller->keyboard_container_initialized())
+ keyboard_controller->OnRootWindowResized(parent_container_->bounds());
}
} // namespace ash
sadrul 2015/04/01 06:43:48 Is this layout-manager necessary at all? KeyboardC
bshe 2015/04/01 20:41:33 Looks like we dont need it. I removed the layout m

Powered by Google App Engine
This is Rietveld 408576698