Allow javascript change the virtual keyboard window size and position freely in FLOATING mode

ash/root_window_controller_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/root_window_controller.h"
 
 #include "ash/session/session_state_delegate.h"
 #include "ash/shelf/shelf_layout_manager.h"
 #include "ash/shell.h"
 #include "ash/shell_window_ids.h"
@@ skipping 733 matching lines @@
   aura::Window* keyboard_window = controller->proxy()->GetKeyboardWindow();
   keyboard_container->AddChild(keyboard_window);
   keyboard_window->set_owned_by_parent(false);
   keyboard_window->SetBounds(keyboard::KeyboardBoundsFromWindowBounds(
       keyboard_container->bounds(), 100));
   keyboard_window->Show();
 
   gfx::Rect before = ash::Shell::GetScreen()->GetPrimaryDisplay().work_area();
 
   // Notify keyboard bounds changing.
-  controller->NotifyKeyboardBoundsChanging(
-      controller->proxy()->GetKeyboardWindow()->bounds());
+  controller->NotifyKeyboardBoundsChanging(keyboard_container->bounds());
 
   if (!keyboard::IsKeyboardOverscrollEnabled()) {
     gfx::Rect after = ash::Shell::GetScreen()->GetPrimaryDisplay().work_area();
     EXPECT_LT(after, before);
   }
 
   // Mock a login user profile change to reinitialize the keyboard.
   ash::Shell::GetInstance()->OnLoginUserProfilePrepared();
   EXPECT_EQ(ash::Shell::GetScreen()->GetPrimaryDisplay().work_area(), before);
 }
@@ skipping 64 matching lines @@
   keyboard_container->Show();
 
   const int keyboard_height = 100;
   aura::Window* keyboard_window =proxy->GetKeyboardWindow();
   keyboard_container->AddChild(keyboard_window);
   keyboard_window->set_owned_by_parent(false);
   keyboard_window->SetBounds(keyboard::KeyboardBoundsFromWindowBounds(
       keyboard_container->bounds(), keyboard_height));
 
   proxy->EnsureCaretInWorkArea();
-  ASSERT_EQ(keyboard_container->bounds().width(),
+  ASSERT_EQ(root_window->bounds().width(),
             text_input_client.visible_rect().width());
-  ASSERT_EQ(keyboard_container->bounds().height() - keyboard_height,
+  ASSERT_EQ(root_window->bounds().height() - keyboard_height,
             text_input_client.visible_rect().height());

[sadrul, 2015/03/20 17:32:16]

Not sure what this test is checking anymore. Can you explain?

[bshe, 2015/03/27 16:29:16]

I think it is still testing the visible_rect of text_input_client is not
occluded by keyboard window in FULL_WIDTH mode. More specifically, I think it
tests EnsureCaretInRect is called with expected bounds:
https://code.google.com/p/chromium/codesearch/#chromium/src/ui/keyboard/keybo...

 
   if (switches::IsTextInputFocusManagerEnabled()) {
     ui::TextInputFocusManager::GetInstance()->BlurTextInputClient(
         &text_input_client);
   } else {
     input_method->SetFocusedTextInputClient(NULL);
   }
 }
 
 // Tests that the virtual keyboard does not block context menus. The virtual
@@ skipping 91 matching lines @@
 #endif
 
 // Tests that the virtual keyboard correctly resizes with a change to display
 // orientation. See crbug/417612.
 TEST_F(VirtualKeyboardRootWindowControllerTest, MAYBE_DisplayRotation) {
   UpdateDisplay("800x600");
   aura::Window* root_window = Shell::GetPrimaryRootWindow();
   aura::Window* keyboard_container =
       Shell::GetContainer(root_window, kShellWindowId_VirtualKeyboardContainer);
   ASSERT_TRUE(keyboard_container);
+  keyboard::KeyboardController::GetInstance()->ShowKeyboard(false);
   keyboard_container->Show();
-  EXPECT_EQ("0,0 800x600", keyboard_container->bounds().ToString());
+  EXPECT_EQ("0,600 800x0", keyboard_container->bounds().ToString());
 
   UpdateDisplay("600x800");
-  EXPECT_EQ("0,0 600x800", keyboard_container->bounds().ToString());
+  EXPECT_EQ("0,800 600x0", keyboard_container->bounds().ToString());

[sadrul, 2015/03/20 17:32:17]

Why the change in this test?

[bshe, 2015/03/27 16:29:16]

After a screen rotation, we want to make sure that the width of keyboard
container is the same as screen width in default(FULL_WIDTH) mode. So I changed
it in test. The default height of keyboard container is always 0 in default
mode. It is perhaps easier to read if the default height is not 0. I have
updated test.

 }
 
 }  // namespace test
 }  // namespace ash