components/password_manager/core/browser/affiliation_fetch_throttler.cc - Issue 1008373003: Integrate throttling logic into AffiliationBackend.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/affiliation_fetch_throttler.cc

Issue 1008373003: Integrate throttling logic into AffiliationBackend. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comment. Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/password_manager/core/browser/affiliation_fetch_throttler.h ('k') | components/password_manager/core/browser/affiliation_fetch_throttler_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/affiliation_fetch_throttler.cc

diff --git a/components/password_manager/core/browser/affiliation_fetch_throttler.cc b/components/password_manager/core/browser/affiliation_fetch_throttler.cc

index 571697001db1cf04608c362063e1beb37afeb9fb..50baaaf828d1c3a7821621228fe14c638feb3bf6 100644

--- a/components/password_manager/core/browser/affiliation_fetch_throttler.cc

+++ b/components/password_manager/core/browser/affiliation_fetch_throttler.cc

@@ -75,15 +75,14 @@ const int64_t AffiliationFetchThrottler::kGracePeriodAfterReconnectMs =

AffiliationFetchThrottler::AffiliationFetchThrottler(

AffiliationFetchThrottlerDelegate* delegate,

const scoped_refptr<base::SingleThreadTaskRunner>& task_runner,

- scoped_ptr<base::TickClock> tick_clock)

+ base::TickClock* tick_clock)

: delegate_(delegate),

task_runner_(task_runner),

+ tick_clock_(tick_clock),

state_(IDLE),

has_network_connectivity_(false),

is_fetch_scheduled_(false),

- tick_clock_(tick_clock.Pass()),

- exponential_backoff_(

- new BackoffEntryImpl(&kBackoffPolicy, tick_clock_.get())),

+ exponential_backoff_(new BackoffEntryImpl(&kBackoffPolicy, tick_clock_)),

weak_ptr_factory_(this) {

DCHECK(delegate);

// Start observing before querying the current connectivity state, so that if