Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1008373002: cc: Remove is_analysis parameter in RasterCommon (Closed)

Created:
5 years, 9 months ago by JungJik
Modified:
5 years, 9 months ago
Reviewers:
vmpstr
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Remove is_analysis parameter in RasterCommon is_analysis parameter is deprecated. This patch is for removing the unused parameter. Committed: https://crrev.com/3b22b38711df713a62e8f059dd9cdacc96e6c803 Cr-Commit-Position: refs/heads/master@{#321097}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -30 lines) Patch
M cc/resources/display_list_raster_source.h View 1 1 chunk +1 line, -2 lines 0 comments Download
M cc/resources/display_list_raster_source.cc View 1 2 chunks +4 lines, -5 lines 0 comments Download
M cc/resources/picture_pile_impl.h View 1 chunk +4 lines, -6 lines 0 comments Download
M cc/resources/picture_pile_impl.cc View 3 chunks +7 lines, -17 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
JungJik
PTAL
5 years, 9 months ago (2015-03-17 04:15:27 UTC) #3
vmpstr
lgtm
5 years, 9 months ago (2015-03-17 15:51:05 UTC) #4
JungJik
On 2015/03/17 15:51:05, vmpstr wrote: > lgtm thanks for the review.
5 years, 9 months ago (2015-03-18 08:20:08 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1008373002/10003
5 years, 9 months ago (2015-03-18 08:20:20 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:10003)
5 years, 9 months ago (2015-03-18 10:14:36 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-18 10:15:27 UTC) #9
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/3b22b38711df713a62e8f059dd9cdacc96e6c803
Cr-Commit-Position: refs/heads/master@{#321097}

Powered by Google App Engine
This is Rietveld 408576698