Fix invalid class names passed to ClassLoader.loadClass.

Fix invalid class names passed to ClassLoader.loadClass.

Substitute slashes for dots in the class name if we are going to pass it
to ClassLoader.loadClass via JNI, instead of calling JNIEnv::FindClass.
This avoids spamming the log with warnings from Dalvik about invalid
class names; it was working correctly anyway due to implementation
details of the VM, but we shouldn't be doing this.

This is not the ideal solution to the problem but is a relatively safe
and isolated fix we can cherrypick to a release branch while we work on
a better one.

BUG=461773
R=rmcilroy

Committed: https://crrev.com/c16354c567b13a6ce3f9b3d8e4c3af61ee3b8c71
Cr-Commit-Position: refs/heads/master@{#320816}

[rmcilroy, 2015-03-16 18:13:16]

lgtm once comments are addressed, thanks.

https://codereview.chromium.org/1008363004/diff/1/base/android/jni_android.cc
File base/android/jni_android.cc (right):

https://codereview.chromium.org/1008363004/diff/1/base/android/jni_android.cc...
base/android/jni_android.cc:167: // JNI generator to generate dot-separated
names.
nit - please link to the bug here.

https://codereview.chromium.org/1008363004/diff/1/base/android/jni_android.cc...
base/android/jni_android.cc:171: for (size_t i=0; i<bufsize; ++i) {
spaces between '=' and '<' operators.

[Torne, 2015-03-16 20:53:30]

https://codereview.chromium.org/1008363004/diff/1/base/android/jni_android.cc
File base/android/jni_android.cc (right):

https://codereview.chromium.org/1008363004/diff/1/base/android/jni_android.cc...
base/android/jni_android.cc:167: // JNI generator to generate dot-separated
names.
On 2015/03/16 18:13:16, rmcilroy wrote:
> nit - please link to the bug here.

Done.

https://codereview.chromium.org/1008363004/diff/1/base/android/jni_android.cc...
base/android/jni_android.cc:171: for (size_t i=0; i<bufsize; ++i) {
On 2015/03/16 18:13:16, rmcilroy wrote:
> spaces between '=' and '<' operators.

Done.

[Torne, 2015-03-16 20:54:00]

The CQ bit was checked by torne@chromium.org

[Torne, 2015-03-16 20:54:00]

The patchset sent to the CQ was uploaded after l-g-t-m from
rmcilroy@chromium.org
Link to the patchset: https://codereview.chromium.org/1008363004/#ps20001
(title: "Address nits")

[commit-bot: I haz the power, 2015-03-16 20:54:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1008363004/20001

[commit-bot: I haz the power, 2015-03-16 22:53:39]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-03-16 22:55:09]

Patchset 2 (id:??) landed as
https://crrev.com/c16354c567b13a6ce3f9b3d8e4c3af61ee3b8c71
Cr-Commit-Position: refs/heads/master@{#320816}